fix: re-enable IAM auth for custom types (#2961) #2971
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
atierian
approved these changes
Oct 21, 2024
iartemiev
approved these changes
Oct 21, 2024
palpatim
added a commit
that referenced
this pull request
Oct 22, 2024
1 task
tejas2008
pushed a commit
that referenced
this pull request
Oct 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
NOTE TO REVIEWERS This PR re-applies #2961, which was previously approved and merged, but which I reverted due to failures manually testing the supported use cases. It turns out that those failures were unrelated, so the change itself is safe.
This PR is the basis of #2968, which introduces an E2E suite to test combinations of
enableIamAuthorizationModewith IAM access to custom Queries and Mutations.Issue #, if available
#2929
Description of how you validated changes
See #2968
Checklist
yarn testpassesBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.