Revert "fix: enable IAM auth for custom types (#2961)" #2964
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 8fc24f3.
iartemiev
approved these changes
Oct 17, 2024
phani-srikar
approved these changes
Oct 17, 2024
Member
Author
|
References #2929 |
tejas2008
pushed a commit
that referenced
this pull request
Oct 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts commit 8fc24f3.
We discovered that a Gen 2 schema without a model (which was the use case the original PR was intended to fix) won't actually deploy, even though it synthesizes as expected. I don't believe this is a regression, but I'm reverting the change until I get E2E coverage on the change to ensure we don't accidentally introduce a regression.
Description of how you validated changes
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.