-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changed the way text is rendered (Fixes: #47) #48
Conversation
@skanehira Can you re-check the wide char support? @glvr182 sorry for the commit mess, lazygit pushed the merge changes to origin in-staid of my remote. |
Code looks good, @skanehira if you could test this I'll accept the code.
|
Most positions are now based on the lines instaid of the actual view. This removes a lot of complicated code because we don't have to worry anymore about the view offset. Improved line wrapping by a lot no wired cursor movement anymore.
57e883a
to
d9bfd68
Compare
I'm going to wait with merging this until the switch to TCell is dune, this pr changes quite a bit core logic and if we merge it now end users might have to change there code a bit 2 times. |
Cannot wait for this to be merged! |
@glvr182 Should we also merge this in? |
Sounds good! We can then test both the upgrade and this new method of rendering |
A new beta release is up with the tcell and these changes, |
This pr changes the way text is rendered.
The way text wrapping works right now supper buggy.
Beside that there are some really dumb calculations dune because some positions are based on the view offset what makes working with this a bit annoying.
I changed most positions in the view to be based on the lines and not the actual line wrappings what makes working with then much easier and less buggy.