Cannot reset cursor position after clicking on the modal

[kristijanhusak]

Describe the bug
I'm not sure if this is bug with gocui, but i'll report it here, you'll know better.
When you open a commit message modal, and type few characters, then click with mouse in the middle of the modal, cursor will go to that position. If you continue typing, it will type, but cursor will be at wrong position all the time. Also you cannot delete anything after that happens.

To Reproduce
Steps to reproduce the behavior:

1. Stage some files
2. Open "Commit message" dialog with C
3. Type in few characters
4. Click with mouse in the middle of the commit message dialog
5. Continue typing, notice the behavior of the cursor
6. Try deleting with backspace, nothing happens

Expected behavior
I guess either cursor should jump back to the right position or clicking in the middle of modal should not even trigger cursor movement.

Screenshots
I'm not able to make a screenshot that shows the cursor for me, i'm probably using bad tool for it.

Desktop (please complete the following information):

• OS: Linux
• Lazygit Version - Unversioned, using from git
• Commit: master branch - 205d731

Additional context
restarting lazygit fixes it.

[jesseduffield]

Yeah I've seen this as well. I believe over in awesome/gocui work is being done to make the editing experience better wrt cursors: awesome-gocui/gocui#48

[kristijanhusak]

@jesseduffield I pulled latest change (via go get), and it's still happening. I also verified that latest gocui vendor vas pulled.

[jesseduffield]

my bad, should be good now on master!

[kristijanhusak]

Works now, thanks!

[jesseduffield]

no worries :)