chore: promote dev → main (genie mcp registration + rules-ghost fix, v5.260705.5) - #2527
Conversation
plugins/genie/.mcp.json (new) registers the stdio server 'genie mcp' — tools/list verified: genie_board, genie_wish_status, genie_worktree_context, genie_task, genie_active. smart-install.js no longer injects v4-era orchestration rules into ~/.claude/rules on SessionStart (this fought genie install's v4 cleanup and resurrected the stale file); rules/genie-orchestration.md rewritten lean-v5 plugin-native (59->20, zero dead verbs); review-criteria dead skill names fixed; tmux error string modernized. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01N1FLEV2Qse3jbX5Wz1sjWE
…ghost fix(plugin): register genie mcp server, stop stale v4 rules injection
📝 WalkthroughWalkthroughThis PR bumps the genie plugin/package version from 5.260705.4 to 5.260705.5 across multiple manifest files, adds a new ChangesVersion Bump and MCP Configuration
Documentation Rewrite
Estimated code review effort: 2 (Simple) | ~10 minutes Possibly related PRs
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request bumps the genie plugin version to 5.260705.5 across several configuration files and adds an MCP server configuration. It refactors the agent orchestration documentation to reflect v5, transitioning to a zero-daemon, SQLite-backed task database model. Additionally, the rule injection logic has been removed from smart-install.js as rules are now loaded natively, and the tmux installation warning has been updated. There are no review comments, and I have no feedback to provide.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: cced8b5ede
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| // NOTE: this script used to copy rules/genie-orchestration.md into | ||
| // ~/.claude/rules/ on version change. That injection is gone: the rules file | ||
| // is plugin-native (loaded from the plugin itself), and the copy kept | ||
| // resurrecting a file that `genie install`'s v4 cleanup deletes. |
There was a problem hiding this comment.
When a user upgrades the plugin from the previous release without re-running genie install, this removal leaves the previously injected ~/.claude/rules/genie-orchestration.md in place. That file was written by this hook and contains the old genie spawn/genie team create/“NEVER use Agent” guidance; the cleanup this comment relies on is only in the genie install finisher (src/genie-commands/install.ts lines 2-7), not in SessionStart. In that upgrade path Claude keeps loading a stale global rule that conflicts with the new plugin-native v5 guidance, so the hook should delete marker-matched rules or invoke the cleanup instead of only stopping the copy.
Useful? React with 👍 / 👎.
| { | ||
| "mcpServers": { | ||
| "genie": { | ||
| "command": "genie", |
There was a problem hiding this comment.
On installs where genie is not on the non-interactive PATH, this static plugin MCP config registers a server that Claude cannot spawn. The existing project registration path explicitly avoids bare genie and writes process.execPath because the binary may only live under ~/.genie/bin (src/term-commands/init.ts lines 156-165, README lines 115-120), so users can have a valid install while this plugin-level server still fails. Use an absolute or shell-resolved command here, or rely on the genie init/launch generated MCP configs.
Useful? React with 👍 / 👎.
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@plugins/genie/.mcp.json`:
- Around line 4-5: The MCP config is still using a PATH-dependent bare command
name instead of an absolute executable path. Update the genie MCP entry in the
manifest to use the full executable path for the command while keeping the
existing args, and make sure the plugin manifest stays consistent with the
contract enforced by registerMcpConfigs() and its tests.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: ASSERTIVE
Plan: Pro
Run ID: 887500a0-03cd-47fc-8f5c-991041eaa20f
⛔ Files ignored due to path filters (1)
plugins/genie/scripts/smart-install.jsis excluded by!plugins/genie/scripts/**
📒 Files selected for processing (7)
.claude-plugin/marketplace.jsonpackage.jsonplugins/genie/.claude-plugin/plugin.jsonplugins/genie/.mcp.jsonplugins/genie/package.jsonplugins/genie/references/review-criteria.mdplugins/genie/rules/genie-orchestration.md
| "command": "genie", | ||
| "args": ["mcp"] |
There was a problem hiding this comment.
🎯 Functional Correctness | 🟠 Major | ⚡ Quick win
Use the absolute executable path here.
Hard-coding genie makes this config PATH-dependent and breaks the same contract that registerMcpConfigs() and its tests enforce: the MCP server should launch via an absolute executable path, not a bare name.
Suggested fix
- "command": "genie",
+ "command": "<absolute genie path>",As per path instructions, verify plugin manifest updates are consistent.
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In `@plugins/genie/.mcp.json` around lines 4 - 5, The MCP config is still using a
PATH-dependent bare command name instead of an absolute executable path. Update
the genie MCP entry in the manifest to use the full executable path for the
command while keeping the existing args, and make sure the plugin manifest stays
consistent with the contract enforced by registerMcpConfigs() and its tests.
Source: Path instructions
1 participant
Promotion: 2 commits
genie mcpstdio server via plugin.mcp.json(tools verified live:genie_board,genie_wish_status,genie_worktree_context,genie_task,genie_active); removes the SessionStart injection of stale v4 orchestration rules into~/.claude/rules/(the confirmed ghost-restorer fightinggenie install's v4 cleanup); plugin rules rewritten lean-v5 (59→20, zero dead verbs); review-criteria + tmux-string dead names fixed.chore(version): bump to 5.260705.5 [auto-version]— the version-race fix proving itself: this tag/release cut fully autonomously on the natural dev merge (no manual dispatch, first time tonight).Diff shape verified: 8 files, +36/−127, all under plugins/genie/ + version-stamped manifests. Release v5.260705.5 publishing now; on merge, the stable channel + marketplace advance and
/pluginupdate + restart surfaces the genie MCP server.🤖 Generated with Claude Code
https://claude.ai/code/session_01N1FLEV2Qse3jbX5Wz1sjWE
Summary by CodeRabbit
New Features
Documentation
Chores
5.260705.5.