chore: version bump for --continue release - #665
Conversation
…663) Replace all `--resume <uuid>` usage with `--continue <name>` for session resumption. Claude Code natively supports resuming sessions by their `--name` value, making UUID-based session tracking unnecessary. - provider-adapters: emit --continue instead of --resume - team-lead-command: resumeSessionId → continueName - session.ts: remove findLastSessionId JSONL scraping, use name-based continue - genie.ts: remove session-store import, use --continue with name directly - auto-spawn: remove lastSessionId usage from spawn args - protocol-router: derive continue name from template (${team}-${role}) - protocol-router-spawn: resumeSessionId → continueName, update log message - agent-registry: remove lastSessionId from WorkerTemplate - agents.ts: remove lastSessionId from template saves - spawn-command: emit --continue instead of --resume - Delete session-store.ts (dead code) - Update all tests Wish: session-continue-by-name Co-authored-by: Genie <genie@automagik.ai>
|
Caution Review failedThe pull request is closed. ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Pro Run ID: 📒 Files selected for processing (5)
📝 WalkthroughWalkthroughVersion number updated from 3.260318.4 to 3.260318.1 across five manifest and package configuration files for the main package and Genie plugin. Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Possibly related PRs
✨ Finishing Touches🧪 Generate unit tests (beta)
📝 Coding Plan
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request primarily focuses on adjusting version numbers across various configuration and package files to ensure a specific version of the Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request intends to perform a version bump for a new release. However, all version numbers in the changed files have been decreased from 3.260318.4 to 3.260318.1. This is a critical issue because package managers like npm require version numbers to be incremented for new publications. Decreasing the version will likely prevent the new release from being published. I have added a comment to package.json to highlight this problem.
| { | ||
| "name": "@automagik/genie", | ||
| "version": "3.260318.4", | ||
| "version": "3.260318.1", |
There was a problem hiding this comment.
The version has been decreased from 3.260318.4 to 3.260318.1. This contradicts the pull request's goal of a 'version bump' for a new release. Package managers like npm do not allow publishing a version that is lower than an already published version. To release a fix, the version number must be incremented. If 3.260318.4 is the latest published version, the next version should be higher, for example 3.260318.5.
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 53c99bd54d
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| { | ||
| "name": "@automagik/genie", | ||
| "version": "3.260318.4", | ||
| "version": "3.260318.1", |
There was a problem hiding this comment.
Keep release versions monotonic
This change lowers the published version from 3.260318.4 to 3.260318.1, which makes the new release sort as older than the previous one; in environments already on 3.260318.4, the update check path (scripts/tmux/genie-update-check.sh, lines 81–89) only advertises updates when latest_version is greater via sort -V, so users will not be prompted to upgrade to the commit that is supposed to ship the --continue fix.
Useful? React with 👍 / 👎.
Force new version so npm publishes the --continue fix. Merge commit only.
Summary by CodeRabbit