Skip to content

fix(plugin): register genie mcp server, stop stale v4 rules injection - #2526

Merged
namastex888 merged 1 commit into
devfrom
fix/plugin-mcp-and-rules-ghost
Jul 5, 2026
Merged

namastex888 merged 1 commit into
devfrom
fix/plugin-mcp-and-rules-ghost

Conversation

@namastex888

Copy link
Copy Markdown
Contributor

Two plugin gaps found while dogfooding the fresh v5.260705.4 install

  1. No MCP registration — genie mcp is a working stdio MCP server, but the plugin never declared it, so Claude Code never spawns it. New plugins/genie/.mcp.json registers it; tools/list verified live: genie_board, genie_wish_status, genie_worktree_context, genie_task, genie_active.
  2. SessionStart ghost-restorer — smart-install.js injected the stale v4 rules/genie-orchestration.md (dead daemon-era verbs; its fallback even said 'Never use native Agent/SendMessage tools') into ~/.claude/rules/ on every session, resurrecting the exact file genie install's v4 cleanup removes (observed twice, byte-identical). Injection removed; the plugin rules file rewritten lean-v5 plugin-native (59→20 lines, zero dead verbs, commands live-verified); review-criteria dead skill names fixed; tmux error string modernized.

Gates

check:fast green (typecheck, biome 113 files, knip, skills:lint 28 files, wishes:lint); node --check on smart-install.js; MCP initialize + tools/list probes green; independently reviewed — SHIP.

🤖 Generated with Claude Code

https://claude.ai/code/session_01N1FLEV2Qse3jbX5Wz1sjWE

plugins/genie/.mcp.json (new) registers the stdio server 'genie mcp' —
tools/list verified: genie_board, genie_wish_status,
genie_worktree_context, genie_task, genie_active.
smart-install.js no longer injects v4-era orchestration rules into
~/.claude/rules on SessionStart (this fought genie install's v4 cleanup
and resurrected the stale file); rules/genie-orchestration.md rewritten
lean-v5 plugin-native (59->20, zero dead verbs); review-criteria dead
skill names fixed; tmux error string modernized.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01N1FLEV2Qse3jbX5Wz1sjWE
@coderabbitai

coderabbitai Bot commented Jul 5, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Pro

Run ID: 86aebf3d-86a0-413e-92ef-9351b998377f

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/plugin-mcp-and-rules-ghost

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@namastex888
namastex888 merged commit 9ed88b0 into dev Jul 5, 2026
11 checks passed

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the Genie plugin to version 5. It introduces an MCP server configuration, updates command references in the review criteria, simplifies the agent orchestration rules, and removes the legacy orchestration prompt injection logic from the installation script. As there are no review comments, I have no feedback to provide.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 98dce5ded4

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread plugins/genie/.mcp.json
{
"mcpServers": {
"genie": {
"command": "genie",

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Resolve the MCP command to the installed binary

For users whose Claude Code process does not have genie on PATH, this plugin-level MCP registration will fail to spawn the server even though the CLI is installed. The repo's own project MCP writer deliberately records process.execPath instead of bare "genie" because the installed binary can live only under ~/.genie/bin/genie and MCP spawners don't reliably inherit shell PATH (src/term-commands/init.ts). This new config should use a wrapper or absolute resolver instead of depending on PATH.

Useful? React with 👍 / 👎.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant