upsert overlap #1238
Draft
upsert overlap #1238
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
area/datastore
ecordell
force-pushed
the
select-overlap
branch
from
a067d3f
to
6c2716f
Compare
This reverts commit 34a4202.
Hashring test perf fix
This changes the default for OTEL sample ratio to be 1% instead of 20%. Our experience running SpiceDB in production has made it clear that 20% is far too large of a default sample ratio for most deployments.
gomod: bump cobrautil
Appeared to be a race condition Stress output: $ stress ./server.test -test.run=TestServerGracefulTermination -test.cpu=2 -test.timeout=5s 5s: 951 runs so far, 0 failures 10s: 1992 runs so far, 0 failures 15s: 3071 runs so far, 0 failures 20s: 4134 runs so far, 0 failures 25s: 5159 runs so far, 0 failures 30s: 6215 runs so far, 0 failures Fixes authzed#1236
Fix flakiness of graceful termination test
Also unblocks moving forward on gRPC Fixes authzed#1247
Move to v4 of kuberesolver
github-actions
bot
added
area/api http
|
Recent CRDB release notes make it sound as though SELECT FOR UPDATE may work for overlap now - it's worth re-running the tests with new versions. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This uses an
UPSERTto create transaction overlap in CRDB. In benchmarks it appears to be slightly faster than theINSERT ... ON CONFLICT