Fix flakiness of graceful termination test #1250
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
area/CLI
ecordell
reviewed
Apr 4, 2023
pkg/cmd/server/server_test.go
Outdated
| WithHTTPGateway(util.HTTPServerConfig{Enabled: true}), | ||
| WithDashboardAPI(util.HTTPServerConfig{Enabled: true}), | ||
| WithMetricsAPI(util.HTTPServerConfig{Enabled: true}), | ||
| WithHTTPGateway(util.HTTPServerConfig{Enabled: true, Address: fmt.Sprintf("localhost:%d", ports[0])}), |
There was a problem hiding this comment.
you can just do Address: ":" and it should pick a free port
josephschorr
force-pushed
the
graceful-flake
branch
from
8edc32a
to
a3a5cb5
Compare
Appeared to be a race condition Stress output: $ stress ./server.test -test.run=TestServerGracefulTermination -test.cpu=2 -test.timeout=5s 5s: 951 runs so far, 0 failures 10s: 1992 runs so far, 0 failures 15s: 3071 runs so far, 0 failures 20s: 4134 runs so far, 0 failures 25s: 5159 runs so far, 0 failures 30s: 6215 runs so far, 0 failures Fixes authzed#1236
josephschorr
force-pushed
the
graceful-flake
branch
from
a3a5cb5
to
91cab1f
Compare
ecordell
approved these changes
Apr 4, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Appeared to be a race condition
Stress output:
Fixes #1236