Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Test Flake: TestServerGracefulTermination #1236

Closed
ecordell opened this issue Mar 30, 2023 · 0 comments · Fixed by #1250
Closed

Test Flake: TestServerGracefulTermination #1236

ecordell opened this issue Mar 30, 2023 · 0 comments · Fixed by #1250

Comments

@ecordell
Copy link
Contributor

Example: https://github.com/authzed/spicedb/actions/runs/4565810157/jobs/8057452447?pr=1235

panic: test timed out after 10m0s
running tests:
	TestServerGracefulTermination (10m0s)
josephschorr added a commit to josephschorr/spicedb that referenced this issue Apr 4, 2023
@josephschorr
Fix flakiness of graceful termination test
8edc32a 
Appeared to be a race condition

Stress output:

$ stress ./server.test -test.run=TestServerGracefulTermination -test.cpu=2 -test.timeout=5s
5s: 951 runs so far, 0 failures
10s: 1992 runs so far, 0 failures
15s: 3071 runs so far, 0 failures
20s: 4134 runs so far, 0 failures
25s: 5159 runs so far, 0 failures
30s: 6215 runs so far, 0 failures

Fixes authzed#1236
@josephschorr josephschorr mentioned this issue Apr 4, 2023
Merged
josephschorr added a commit to josephschorr/spicedb that referenced this issue Apr 4, 2023
@josephschorr
Fix flakiness of graceful termination test
a3a5cb5 
Appeared to be a race condition

Stress output:

$ stress ./server.test -test.run=TestServerGracefulTermination -test.cpu=2 -test.timeout=5s
5s: 951 runs so far, 0 failures
10s: 1992 runs so far, 0 failures
15s: 3071 runs so far, 0 failures
20s: 4134 runs so far, 0 failures
25s: 5159 runs so far, 0 failures
30s: 6215 runs so far, 0 failures

Fixes authzed#1236
josephschorr added a commit to josephschorr/spicedb that referenced this issue Apr 4, 2023
@josephschorr
Fix flakiness of graceful termination test
91cab1f 
Appeared to be a race condition

Stress output:

$ stress ./server.test -test.run=TestServerGracefulTermination -test.cpu=2 -test.timeout=5s
5s: 951 runs so far, 0 failures
10s: 1992 runs so far, 0 failures
15s: 3071 runs so far, 0 failures
20s: 4134 runs so far, 0 failures
25s: 5159 runs so far, 0 failures
30s: 6215 runs so far, 0 failures

Fixes authzed#1236
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix flakiness of graceful termination test josephschorr/spicedb
1 participant
@ecordell