Skip to content

Conversation

@grounded042
Copy link
Contributor

@grounded042 grounded042 commented Jan 29, 2021

Work for v2 should be done via PRs against the v2 branch. Once we have tackled all of the issues / PRs from the v2 milestone we can do a final review / verification via this PR before officially releasing.

Description

In this release we’ve addressed some long-standing asks and made some major improvements:

  • Replaceable JWT validation - you can now bring your favorite JWT package to validate tokens by ensuring it conforms to a simple interface. We provide two implementations for two different JWT packages.
  • We now support a custom error handler.
  • Under the hood we clone the http.Request instead of a shallow copy in order to better support reverse proxies.
  • We now support extracting JWTs from cookies.
  • We now store the JWT information using a non-string context key to conform to Golang best practices.
  • A caching provider for JWKS is now provided to help you with rate limits from your identity provider.
  • We’ve switched errors to use github.com/pkg/errors to provide better error context. If you’re not familiar with the package, don’t worry as it adheres to the error interface.

@codecov-commenter
Copy link

codecov-commenter commented May 14, 2021

Codecov Report

Merging #75 (66a443b) into master (d600c10) will increase coverage by 45.58%.
The diff coverage is 91.45%.

Impacted file tree graph

@@             Coverage Diff             @@
##           master      #75       +/-   ##
===========================================
+ Coverage   46.83%   92.42%   +45.58%     
===========================================
  Files           1        3        +2     
  Lines          79      132       +53     
===========================================
+ Hits           37      122       +85     
+ Misses         30        9       -21     
+ Partials       12        1       -11     
Impacted Files Coverage Δ
validate/josev2/josev2.go 85.71% <85.71%> (ø)
jwtmiddleware.go 93.75% <91.83%> (+46.91%) ⬆️
validate/jwt-go/jwtgo.go 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d600c10...66a443b. Read the comment docs.

@sergiught sergiught changed the title holding for v2 Release v2.0.0 Nov 1, 2021
@sergiught sergiught marked this pull request as ready for review November 1, 2021 10:01
@sergiught sergiught requested a review from a team as a code owner November 1, 2021 10:01
@sergiught sergiught requested a review from a team November 1, 2021 10:01
Copy link
Contributor

@Widcket Widcket left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR contains aggregated changes that were already reviewed in individual PRs.

@sergiught sergiught merged commit 2a698ca into master Nov 1, 2021
@sergiught sergiught deleted the v2 branch November 1, 2021 11:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants