fix: CheckJWT clones the request #89
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jfatta
force-pushed
the
v2-fix-clone-request
branch
from
2bfab37 to
3e76a58
Compare
grounded042
reviewed
May 21, 2021
jwtmiddleware.go
Outdated
| // no err means we have a valid token, so set it into the | ||
| // context and continue onto next | ||
| *r = *r.Clone(context.WithValue(r.Context(), ContextKey{}, validToken)) | ||
| r = r.Clone(context.WithValue(r.Context(), ContextKey{}, validToken)) |
There was a problem hiding this comment.
yup, good catch on this
sergiught
pushed a commit
that referenced
this pull request
Nov 1, 2021
* fix: clone request with ctx * fix unnecessary pointer
d10i
pushed a commit
to Hikely/go-jwt-middleware
that referenced
this pull request
Nov 2, 2021
* fix: clone request with ctx * fix unnecessary pointer
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #62
I'll keep it as draft until tests are working onv2branch.