feat: add JWKS provider to the josev2 validator #97
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jon Carl <[email protected]>
Signed-off-by: Jon Carl <[email protected]>
Signed-off-by: Jon Carl <[email protected]>
Signed-off-by: Jon Carl <[email protected]>
Signed-off-by: Jon Carl <[email protected]>
Signed-off-by: Jon Carl <[email protected]>
Signed-off-by: Jon Carl <[email protected]>
Signed-off-by: Jon Carl <[email protected]>
Codecov Report
@@ Coverage Diff @@
## v2 #97 +/- ##
==========================================
- Coverage 92.42% 85.55% -6.87%
==========================================
Files 3 3
Lines 132 180 +48
==========================================
+ Hits 122 154 +32
- Misses 9 21 +12
- Partials 1 5 +4
Continue to review full report at Codecov.
|
Signed-off-by: Jon Carl <[email protected]>
wimdec
reviewed
Jul 12, 2021
| validator, err := josev2.New( | ||
| // p.KeyFunc, // uncomment this to use the caching key provider | ||
| keyFunc, | ||
| jose.HS256, |
There was a problem hiding this comment.
When using JWKS, this will in most cases be RS256 instead of HS256?
wimdec
reviewed
Jul 12, 2021
|
Maybe also update example: https://github.com/auth0/go-jwt-middleware/tree/v2/validate/josev2/examples ? |
|
@wimdec thanks for the review! I think I'll break out a second example for JWKS specifically. |
Signed-off-by: Jon Carl <[email protected]>
Signed-off-by: Jon Carl <[email protected]>
sergiught
pushed a commit
that referenced
this pull request
Nov 1, 2021
d10i
pushed a commit
to Hikely/go-jwt-middleware
that referenced
this pull request
Nov 2, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Many times JWTs will be signed with a JWKS. When working with JWKS it is beneficial to cache the keys used to check token in order to decrease request round-trip and keep from potentially hitting identity provider rate limits. This PR adds a JWKS provider to the josev2 validator as well as a caching JWKS provider.