Remove unneeded nightly feature#94
Closed
matklad wants to merge 9 commits intoaurora-is-near:masterfrom
Closed
Conversation
* Base precompile code between connectors * Handle errors and validate input * Use proper result
matklad
commented
May 18, 2021
birchmd
approved these changes
May 18, 2021
* Validate register length in `read_input_arr20()` * Only read register length in `Engine::get_code_size` * Add `read_input_borsh()` * Ensure `method.args.len() == args_decoded.len()` * Ensure register size is 8 in `read_u64` * Use constant to specify the register ID used in `read_input()`
Contributor
|
@matklad @joshuajbouw Please retarget this at the |
At the moment, running `cargo check` locally for me: * fails with some compilation error in the dependency * updates Cargo.lock That is, the Cargo.lock that is committed into the repo doesn't work. To prevent this from happening in the future, let's forbid CI from upgrading Cargo.lock.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On wasm, intrinsic for trap unreachable is stable and exposed via
core::arch, no need for a nightly feature.Wasn't able to verify if this compiles due to #93.