Ensure that Cargo.lock in the repo is valid#93
Ensure that Cargo.lock in the repo is valid#93matklad wants to merge 9 commits intoaurora-is-near:masterfrom
Conversation
* Base precompile code between connectors * Handle errors and validate input * Use proper result
|
This is more of an issue, rather than a pull-request -- to merge this, a working Cargo.lock needs to be supplied, and I won't be looking into fixing that. |
birchmd
left a comment
birchmd
left a comment
There was a problem hiding this comment.
cargo check works for me. I'm not sure how Cargo.lock could have been corrupted since it is always autogenerated. That said, I don't see the harm in adding --locked.
It is not corrupted, it just doesn't match Cargo.toml. So, running I attributed local |
* Validate register length in `read_input_arr20()` * Only read register length in `Engine::get_code_size` * Add `read_input_borsh()` * Ensure `method.args.len() == args_decoded.len()` * Ensure register size is 8 in `read_u64` * Use constant to specify the register ID used in `read_input()`
|
@matklad @joshuajbouw Please retarget this at the |
At the moment, running `cargo check` locally for me: * fails with some compilation error in the dependency * updates Cargo.lock That is, the Cargo.lock that is committed into the repo doesn't work. To prevent this from happening in the future, let's forbid CI from upgrading Cargo.lock.
artob
added
C-bug
5 participants
At the moment, running
cargo checklocally for me:That is, the Cargo.lock that is committed into the repo doesn't work. To
prevent this from happening in the future, let's forbid CI from
upgrading Cargo.lock.