Skip to content

Math API ecrecover and ripemd160 extension#4380

Merged
bowenwang1996 merged 163 commits intonear:masterfrom
joshuajbouw:feat/evm/math-extension
Jun 30, 2021
Merged

Math API ecrecover and ripemd160 extension#4380
bowenwang1996 merged 163 commits intonear:masterfrom
joshuajbouw:feat/evm/math-extension

Conversation

@joshuajbouw
Copy link
Copy Markdown
Member

@joshuajbouw joshuajbouw commented Jun 20, 2021

Summary

As a successor to #3954, this PR is meant to speed up and lower the cost of the Aurora EVM contract cost by adding several new methods to the nearcore Math API logic. Notably, ecrecover is extremely important as it is the most expensive method.

Todo

  • Removed blake2
  • Rework ecrecover to use near-crypto and not a new lib
  • Remove protocol_feature_evm conditional compilation which were added
  • Add protocol_feature_math_extension feature
  • Params estimator

References:

@joshuajbouw joshuajbouw force-pushed the feat/evm/math-extension branch from bffcbeb to 94dddaf Compare June 25, 2021 17:16
@joshuajbouw joshuajbouw force-pushed the feat/evm/math-extension branch from 94dddaf to ac53dcb Compare June 25, 2021 17:31
Comment thread core/crypto/src/signature.rs Outdated
Comment thread runtime/near-vm-logic/src/logic.rs Outdated
Comment thread core/primitives-core/src/config.rs
@joshuajbouw
Copy link
Copy Markdown
Member Author

joshuajbouw commented Jun 29, 2021

Provided CI is good to go, I just need the params estimator numbers, and good to push in. @nearmax @bowenwang1996

@joshuajbouw joshuajbouw force-pushed the feat/evm/math-extension branch from 59ef8a4 to 6c7401d Compare June 29, 2021 13:43
@joshuajbouw joshuajbouw force-pushed the feat/evm/math-extension branch from 6c7401d to 23f91e8 Compare June 29, 2021 13:43
Copy link
Copy Markdown
Collaborator

@bowenwang1996 bowenwang1996 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just need the new fees :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.