EIP-2718: Typed Transaction Envelope support#165
Merged
Conversation
Contributor
|
This can be improved, I think. I'll play around with it based on the idea that I had. EDIT: Ah ok, I see then we can add the new tx type afterwards. |
joshuajbouw
suggested changes
Jun 29, 2021
Contributor
joshuajbouw
left a comment
joshuajbouw
left a comment
There was a problem hiding this comment.
Code looks fine, but from what I understand is that we would need a hard fork enum of some sort perhaps. If we push it in as now and it makes it into the engine, we need to change all tx if I'm not mistakened.
Perhaps a precursor PR is required that will link up other parts such as the precompiles.
joshuajbouw
approved these changes
Jun 29, 2021
Contributor
joshuajbouw
left a comment
joshuajbouw
left a comment
There was a problem hiding this comment.
Yeah this is ok. Thanks for the clarification.
artob
added a commit
that referenced
this pull request
Jul 8, 2021
* Fix scheduled nightly clippy. (#160) * Always compile tests with the `mainnet` feature. (#162) * Move eth-connector tests to under `src/tests`. (#164) * EIP-2718: Support typed transaction envelopes. (#165) * Remove deprecated EIP-712 prover implementation. (#168) * ERC-20: Allow admin to change token metadata. (#171) Co-authored-by: Evgeny Ukhanov <evgeny@aurora.dev> Co-authored-by: Kirill <kirill@aurora.dev> Co-authored-by: Michael Birch <michael@aurora.dev>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
EIP-2718 is required for the Berlin HardFork.
Spec: https://eips.ethereum.org/EIPS/eip-2718
This change is pretty minimal because it doesn't specify any new transaction types, only the format that new types will use. For example, when we add EIP-2930 support then we will add a new variant to the
EthTransactionenum introduced in this PR.