Remove Prover - deprecated EIP-712 implementation#168
Merged
Conversation
sept-en
approved these changes
Jul 1, 2021
Contributor
sept-en
left a comment
sept-en
left a comment
There was a problem hiding this comment.
LGTM!
Added a couple of minor comments that I think worth addressing in this PR. If you don't think so, just ignore and let's add this in the following ones.
joshuajbouw
approved these changes
Jul 5, 2021
Contributor
joshuajbouw
left a comment
joshuajbouw
left a comment
There was a problem hiding this comment.
Whoops forgot to push this review in on Friday. @sept-en is right on the return. Besides that, good to go.
sept-en
approved these changes
Jul 5, 2021
sept-en
reviewed
Jul 6, 2021
Co-authored-by: Kirill <kirill@aurora.dev>
artob
added a commit
that referenced
this pull request
Jul 8, 2021
* Fix scheduled nightly clippy. (#160) * Always compile tests with the `mainnet` feature. (#162) * Move eth-connector tests to under `src/tests`. (#164) * EIP-2718: Support typed transaction envelopes. (#165) * Remove deprecated EIP-712 prover implementation. (#168) * ERC-20: Allow admin to change token metadata. (#171) Co-authored-by: Evgeny Ukhanov <evgeny@aurora.dev> Co-authored-by: Kirill <kirill@aurora.dev> Co-authored-by: Michael Birch <michael@aurora.dev>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related to: #114