Fix NEP-141 Compliance#158
Merged
Merged
Conversation
Return number as json (string) in ft_on_transfer
sept-en
approved these changes
Jun 22, 2021
Contributor
sept-en
left a comment
sept-en
left a comment
There was a problem hiding this comment.
Good catch! LGTM!
Please fix tests and let's merge this ASAP.
birchmd
approved these changes
Jun 22, 2021
Member
birchmd
left a comment
birchmd
left a comment
There was a problem hiding this comment.
As @mfornet has already mentioned, explicitly putting quotes around outputs in some places is quite error prone.
Approving for the sake of quickly addressing this bug, but we should definitely find a more robust way to handle this in the future (e.g. functions that are supposed to return json return a JsonValue and then output can be always be serialized using the same logic).
Co-authored-by: Michael Birch <michael@near.org>
sept-en
added
C-bug
Contributor
Author
|
Thanks for fixing tests @sept-en |
artob
added a commit
that referenced
this pull request
Jun 23, 2021
* Remove engine feature flag. (#154) * Move tests to `src/tests`. (#155) * Improve the `EvmErc20.sol` contract. (#156) * Properly document endianess. (#157) * Fix NEP-141 compliance. (#158) Co-authored-by: Ahmed Ali <ahmed@aurora.dev> Co-authored-by: Frank Braun <frank@aurora.dev> Co-authored-by: Kirill <kirill@aurora.dev> Co-authored-by: Marcelo Fornet <marcelo@aurora.dev> Co-authored-by: Michael Birch <michael@aurora.dev>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Return number as json (string) in ft_on_transfer