Remove duplicate import of the context contract#156
Merged
Conversation
joshuajbouw
approved these changes
Jun 21, 2021
Contributor
joshuajbouw
left a comment
joshuajbouw
left a comment
There was a problem hiding this comment.
Looks straight forward
artob
approved these changes
Jun 21, 2021
artob
added a commit
that referenced
this pull request
Jun 23, 2021
* Remove engine feature flag. (#154) * Move tests to `src/tests`. (#155) * Improve the `EvmErc20.sol` contract. (#156) * Properly document endianess. (#157) * Fix NEP-141 compliance. (#158) Co-authored-by: Ahmed Ali <ahmed@aurora.dev> Co-authored-by: Frank Braun <frank@aurora.dev> Co-authored-by: Kirill <kirill@aurora.dev> Co-authored-by: Marcelo Fornet <marcelo@aurora.dev> Co-authored-by: Michael Birch <michael@aurora.dev>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The used ERC-20 v4.1.0 already imports the
context.solcontract.Also the EvmERC20 does not follow the openzeppling
msgSenderstyle.