Remove engine feature flag#154
Merged
joshuajbouw merged 2 commits intodevelopfrom Jun 19, 2021
Merged
Conversation
Merged
sept-en
approved these changes
Jun 18, 2021
Contributor
sept-en
left a comment
sept-en
left a comment
There was a problem hiding this comment.
Nice, thanks for doing this!
mrLSD
approved these changes
Jun 18, 2021
joshuajbouw
pushed a commit
that referenced
this pull request
Jun 19, 2021
Per [matklad's blog post](https://matklad.github.io/2021/02/27/delete-cargo-integration-tests.html), it is better in our situation to have all our tests be part of the same compilation artifact (as opposed to rust's "integration tests" which are all compiled separately). In this PR we resolve the conflicting versions of wasmtime which was preventing us from having all our tests in one place. It also moves most of the tests from `tests` to `src/tests` as suggested in the blog post. An additional benefit of moving the tests under the main source directory is being able to easily reuse code in tests (for example I could delete the `AuroraConfig` struct from the state migration test because it duplicated some things from `test_utils`). The only tests that remain in `tests` are the ones for the connector. These in particular have a lot of code duplication from production which will be able to be eliminated once it is brought under `src/tests`. However, we are not doing that in this PR because it needs #154 to be merged first. So it will be done as a follow up PR. One other thing I noticed is that the new `meta-call` feature meant we were not running the tests for meta parsing any more. This is also corrected in this PR.
artob
added a commit
that referenced
this pull request
Jun 23, 2021
* Remove engine feature flag. (#154) * Move tests to `src/tests`. (#155) * Improve the `EvmErc20.sol` contract. (#156) * Properly document endianess. (#157) * Fix NEP-141 compliance. (#158) Co-authored-by: Ahmed Ali <ahmed@aurora.dev> Co-authored-by: Frank Braun <frank@aurora.dev> Co-authored-by: Kirill <kirill@aurora.dev> Co-authored-by: Marcelo Fornet <marcelo@aurora.dev> Co-authored-by: Michael Birch <michael@aurora.dev>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As @mfornet pointed out previously the
enginefeature flag doe not seem to add any value, and in fact is a determent to testing because it hides so much logic.This PR simply removes it.