-
-
Notifications
You must be signed in to change notification settings - Fork 996
chore: update meetings.json and newsrooom_videos.json #3974
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: update meetings.json and newsrooom_videos.json #3974
Conversation
WalkthroughThis pull request updates two JSON configuration files. In Changes
Possibly related PRs
Suggested labels
Suggested reviewers
Poem
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
Documentation and Community
|
✅ Deploy Preview for asyncapi-website ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #3974 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 21 21
Lines 667 667
Branches 113 113
=========================================
Hits 667 667 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (1)
config/meetings.json (1)
72-77: Nitpick: Trailing whitespace in meeting title and date update confirmation.
The "Design WG Meeting " entry (line 73) contains trailing whitespace in the title. Additionally, its date field is updated to"2025-03-20T16:00:00.000Z". Please confirm that the whitespace is intentional and that the revised date correctly reflects the intended schedule.
📜 Review details
Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (2)
config/meetings.json(1 hunks)config/newsroom_videos.json(1 hunks)
⏰ Context from checks skipped due to timeout of 180000ms (6)
- GitHub Check: Redirect rules - asyncapi-website
- GitHub Check: Header rules - asyncapi-website
- GitHub Check: Pages changed - asyncapi-website
- GitHub Check: Automerge PR autoapproved by a bot
- GitHub Check: Test NodeJS PR - macos-13
- GitHub Check: Lighthouse CI
🔇 Additional comments (3)
config/meetings.json (2)
79-85: Approval: New meeting entry "Preventing API Drift: Ensuring Your APIs Stay True to Their Spec".
This new meeting entry has been added with all required fields (calendar link, URL, banner, and ISO8601 date). Please verify that the provided URLs and image asset are correct and that the date is in line with the event’s planned timing.
86-91: Approval: New meeting entry "AsyncAPI Community Working Group Meeting" added.
The new entry appears well formed, with consistent property names and values. Ensure that the scheduled time ("2025-04-08T15:00:00.000Z") is as intended and that it meshes well with the overall meeting schedule in the configuration.config/newsroom_videos.json (1)
2-7: Approval: New video entry for "AsyncAPI Community Working Group Meeting, March 25th 2025".
The added video entry includes all necessary properties (image_url,title,description, andvideoId) and is positioned at the beginning of the array. Please confirm that the details (especially the image URL and video ID) are correct and that the removal of the outdated video entry was intentional.
Automated changes by create-pull-request GitHub action
Summary by CodeRabbit
New Features
Chores