-
-
Notifications
You must be signed in to change notification settings - Fork 996
chore: update meetings.json and newsrooom_videos.json #4033
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: update meetings.json and newsrooom_videos.json #4033
Conversation
WalkthroughThe pull request updates configuration files by adding and modifying entries for AsyncAPI meetings and video listings. In Changes
Possibly related PRs
Suggested labels
Suggested reviewers
Poem
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
Documentation and Community
|
✅ Deploy Preview for asyncapi-website ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #4033 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 21 21
Lines 667 667
Branches 113 113
=========================================
Hits 667 667 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (1)
config/newsroom_videos.json (1)
15-17: Modified Title and DescriptionThe entry that now has the title "AsyncAPI Marketing Working Group Meeting, April 1 2025" with an empty description indicates an intentional update compared to the previous detailed description. Please ensure that an empty description is acceptable for your use case and that this change aligns with the project’s messaging and branding.
📜 Review details
Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (2)
config/meetings.json(1 hunks)config/newsroom_videos.json(2 hunks)
⏰ Context from checks skipped due to timeout of 180000ms (6)
- GitHub Check: Redirect rules - asyncapi-website
- GitHub Check: Header rules - asyncapi-website
- GitHub Check: Pages changed - asyncapi-website
- GitHub Check: Automerge PR autoapproved by a bot
- GitHub Check: Lighthouse CI
- GitHub Check: Test NodeJS PR - macos-13
🔇 Additional comments (2)
config/meetings.json (1)
106-113: New Meeting Entry AdditionA new meeting entry for "AsyncAPI Community Working Group Meeting" scheduled on April 22, 2025 has been added. All required fields (title, calLink, url, banner, date) are present and formatted correctly. Please verify that the event details (especially the calendar link and date) are accurate and that this entry fits into the intended schedule relative to the other meetings.
config/newsroom_videos.json (1)
2-7: New Video Entry AdditionThe new video entry for "AsyncAPI Community Working Group Meeting, April 8th 2025" is well-formed. It includes a proper image URL, title, description (linking to a GitHub issue), and videoId. The fields appear consistent with the expected structure.
Automated changes by create-pull-request GitHub action
Summary by CodeRabbit
New Features
Chores