-
-
Notifications
You must be signed in to change notification settings - Fork 997
chore: update meetings.json and newsrooom_videos.json #3739
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: update meetings.json and newsrooom_videos.json #3739
Conversation
WalkthroughThis pull request updates two configuration files by introducing new entries and removing outdated ones. In Changes
Sequence Diagram(s)sequenceDiagram
participant User
participant Website
participant ConfigLoader
User->>Website: Navigate to Meeting Schedule
Website->>ConfigLoader: Load meetings.json
ConfigLoader-->>Website: Return meetings list (including new AsyncAPI Community WG Meeting)
Website->>User: Display updated meeting schedule
User->>Website: Navigate to Newsroom Videos
Website->>ConfigLoader: Load newsroom_videos.json
ConfigLoader-->>Website: Return videos list (new community meeting entry, removed marketing entry)
Website->>User: Display updated video list
Possibly related PRs
Suggested labels
Suggested reviewers
Poem
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
Documentation and Community
|
✅ Deploy Preview for asyncapi-website ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #3739 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 20 20
Lines 732 732
=========================================
Hits 732 732 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (1)
config/newsroom_videos.json (1)
2-7: New Video Entry Consistency Check
A new video entry for the "AsyncAPI Community Working Group Meeting, February 25th 2025" has been introduced at the beginning of the array. Please double-check that:
- The meeting date in the video title (“February 25th 2025”) is intentionally different from the meeting date (
2025-03-11T15:00:00.000Z) inmeetings.json.- The GitHub issue referenced in the description (
https://github.com/asyncapi/community/issues/1713.) is correct. Note the trailing period in the URL; if this punctuation is unintentional, consider removing it to ensure the URL remains valid.A suggested diff to remove the trailing period (if needed):
- "description": "https://github.com/asyncapi/community/issues/1713.", + "description": "https://github.com/asyncapi/community/issues/1713"
📜 Review details
Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (2)
config/meetings.json(1 hunks)config/newsroom_videos.json(1 hunks)
⏰ Context from checks skipped due to timeout of 180000ms (5)
- GitHub Check: Redirect rules - asyncapi-website
- GitHub Check: Header rules - asyncapi-website
- GitHub Check: Pages changed - asyncapi-website
- GitHub Check: Automerge PR autoapproved by a bot
- GitHub Check: Lighthouse CI
🔇 Additional comments (1)
config/meetings.json (1)
79-84: New Meeting Entry Verification
The new meeting entry for "AsyncAPI Community Working Group Meeting" has been added with the expected keys (title,calLink,url,banner, anddate). Please verify that the scheduled date (2025-03-11T15:00:00.000Z) and the associated GitHub issue (https://github.com/asyncapi/community/issues/1754) accurately reflect the upcoming event details and align with the organizational calendar.
Automated changes by create-pull-request GitHub action
Summary by CodeRabbit