Skip to content

Fix dbt deps of LoadMode.DBT_LS should use ProjectConfig.dbt_vars#1114

Merged
tatiana merged 1 commit into
mainfrom
fix-1112
Jul 23, 2024
Merged

Fix dbt deps of LoadMode.DBT_LS should use ProjectConfig.dbt_vars#1114
tatiana merged 1 commit into
mainfrom
fix-1112

Conversation

@tatiana
Copy link
Copy Markdown
Collaborator

@tatiana tatiana commented Jul 22, 2024

Before, Cosmos would not forward dbt vars set in the ProjectConfig to the dbt deps command run as part of LoadMode.DBT_LS. This PR fixes this behaviour by setting them.

Closes: #1112

@dosubot dosubot Bot added the size:M This PR changes 30-99 lines, ignoring generated files. label Jul 22, 2024
@netlify
Copy link
Copy Markdown

netlify Bot commented Jul 22, 2024

Deploy Preview for sunny-pastelito-5ecb04 canceled.

Name Link
🔨 Latest commit bbbb957
🔍 Latest deploy log https://app.netlify.com/sites/sunny-pastelito-5ecb04/deploys/669ee5b5742ae10008f09fe5

@dosubot dosubot Bot added area:dependencies Related to dependencies, like Python packages, library versions, etc dbt:deps Primarily related to dbt deps command or functionality labels Jul 22, 2024
@tatiana tatiana added this to the Cosmos 1.6.0 milestone Jul 22, 2024
@codecov
Copy link
Copy Markdown

codecov Bot commented Jul 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.47%. Comparing base (e61f3a3) to head (bbbb957).
Report is 3 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1114   +/-   ##
=======================================
  Coverage   96.47%   96.47%           
=======================================
  Files          64       64           
  Lines        3288     3293    +5     
=======================================
+ Hits         3172     3177    +5     
  Misses        116      116           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dosubot dosubot Bot added the lgtm This PR has been approved by a maintainer label Jul 23, 2024
@tatiana tatiana merged commit 236488b into main Jul 23, 2024
@tatiana tatiana deleted the fix-1112 branch July 23, 2024 09:47
@pankajkoti pankajkoti mentioned this pull request Jul 31, 2024
dwreeves pushed a commit to dwreeves/astronomer-cosmos that referenced this pull request Jul 31, 2024
…s` (astronomer#1114)

Before, Cosmos would not forward dbt vars set in the `ProjectConfig` to
the `dbt deps` command run as part of `LoadMode.DBT_LS`. This PR fixes
this behaviour by setting them.

Closes: astronomer#1112
pankajkoti added a commit that referenced this pull request Aug 20, 2024
New Features

* Add support for loading manifest from cloud stores using Airflow
Object Storage by @pankajkoti in #1109
* Cache ``package-lock.yml`` file by @pankajastro in #1086
* Support persisting the ``LoadMode.VIRTUALENV`` directory by @tatiana
in #1079
* Add support to store and fetch ``dbt ls`` cache in remote stores by
@pankajkoti in #1147
* Add default source nodes rendering by @arojasb3 in #1107
* Add Teradata ``ProfileMapping`` by @sc250072 in #1077

Enhancements

* Add ``DatabricksOauthProfileMapping`` profile by @CorsettiS in #1091
* Use ``dbt ls`` as the default parser when ``profile_config`` is
provided by @pankajastro in #1101
* Add task owner to dbt operators by @wornjs in #1082
* Extend Cosmos custom selector to support + when using paths and tags
by @mvictoria in #1150
* Simplify logging by @dwreeves in #1108

Bug fixes

* Fix Teradata ``ProfileMapping`` target invalid issue by @sc250072 in
#1088
* Fix empty tag in case of custom parser by @pankajastro in #1100
* Fix ``dbt deps`` of ``LoadMode.DBT_LS`` should use
``ProjectConfig.dbt_vars`` by @tatiana in #1114
* Fix import handling by lazy loading hooks introduced in PR #1109 by
@dwreeves in #1132
* Fix Airflow 2.10 regression and add Airflow 2.10 in test matrix by
@pankajastro in #1162

Docs

* Fix typo in azure-container-instance docs by @pankajastro in #1106
* Use Airflow trademark as it has been registered by @pankajastro in
#1105

Others

* Run some example DAGs in Kubernetes execution mode in CI by
@pankajastro in #1127
* Install requirements.txt by default during dev env spin up by
@@CorsettiS in #1099
* Remove ``DbtGraph.current_version`` dead code by @tatiana in #1111
* Disable test for Airflow-2.5 and Python-3.11 combination in CI by
@pankajastro in #1124
* Pre-commit hook updates in #1074, #1113, #1125, #1144, #1154,  #1167

---------

Co-authored-by: Pankaj Koti <pankajkoti699@gmail.com>
Co-authored-by: Pankaj Singh <98807258+pankajastro@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:dependencies Related to dependencies, like Python packages, library versions, etc dbt:deps Primarily related to dbt deps command or functionality lgtm This PR has been approved by a maintainer size:M This PR changes 30-99 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[bug] LoadMode.DBT_LS dbt deps not taking into account dbt vars

3 participants