Fix dbt project parsing dbt_vars behavior#1543
Merged
Merged
Conversation
dosubot
Bot
added
the
size:M
AlexandrKhabarov
temporarily deployed
to
external
GitHub Actions
Inactive
dosubot
Bot
added
area:rendering
✅ Deploy Preview for sunny-pastelito-5ecb04 canceled.
|
Contributor
Author
|
@tatiana can you take a look, please? |
pankajastro
approved these changes
Feb 18, 2025
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1543 +/- ##
=======================================
Coverage 97.36% 97.36%
=======================================
Files 80 80
Lines 4932 4932
=======================================
Hits 4802 4802
Misses 130 130 ☔ View full report in Codecov by Sentry. |
pankajkoti
reviewed
Feb 19, 2025
AlexandrKhabarov
had a problem deploying
to
external
GitHub Actions
Error
AlexandrKhabarov
force-pushed
the
fix/dbt-vars-dbt-ls
branch
from
8c7a8c8 to
3bb5ab7
Compare
AlexandrKhabarov
temporarily deployed
to
external
GitHub Actions
Inactive
Contributor
Author
|
@tatiana @pankajkoti |
Collaborator
|
@AlexandrKhabarov, sorry for the delay in giving feedback; this week has been quite intense at work, and I wanted to give enough attention to this review. Please let us know your thoughts on committing @pankajkoti 's suggestion - I would love to have this released as part of Cosmos 1.9.1, with the other bugfixes |
AlexandrKhabarov
force-pushed
the
fix/dbt-vars-dbt-ls
branch
from
56b386e to
f88cc34
Compare
AlexandrKhabarov
temporarily deployed
to
external
GitHub Actions
Inactive
Contributor
Author
|
@tatiana updated PR |
tatiana
approved these changes
Mar 3, 2025
Collaborator
|
Thank you very much, @AlexandrKhabarov. We'll release this as part of Cosmos 1.9.1 this week. |
tatiana
changed the title
dbt_vars behavior
pankajkoti
pushed a commit
that referenced
this pull request
Mar 13, 2025
`DbtToAirflowConverter` can pass dbt_vars to DbtGraph with the help of ProjectConfig or operator_args. If operator_args is used in `DbtToAirflowConverter` then it will lead to the issue with absence of dbt_vars in dbt ls command (faced rendering issue during usage of cosmos with project level variables) (cherry picked from commit 7016dd5)
Closed
tatiana
added a commit
that referenced
this pull request
Mar 17, 2025
Bug Fixes * Fix import error in dbt bigquery adapter mock for ``dbt-bigquery<1.8`` for ``ExecutionMode.AIRFLOW_ASYNC`` by @pankajkoti in #1548 * Fix ``operator_args`` override configuration by @ghjklw in #1558 * Fix missing ``install_dbt_deps`` in ``ProjectConfig`` ``__init__`` method by @ghjklw in #1556 * Fix dbt project parsing ``dbt_vars`` behavior passed via ``operator_args`` by @AlexandrKhabarov in #1543 * Avoid reading the connection during DAG parsing of the async BigQuery operator by @joppevos in #1582 * Fix: Workaround to incorrectly raised ``gcsfs.retry.HttpError`` (Invalid Credentials, 401) by @tatiana in #1598 * Fix the async execution mode read sql files for dbt packages by @pankajastro in #1588 * Improve BQ async error handling by @tatiana in #1597 * Fix path selector when ``manifest.json`` is created using MS Windows by @tatiana in #1601 * Fix log that prints 'Total filtered nodes' by @tatiana in #1603 * Fix select behaviour using ``LoadMode.MANIFEST`` and a path with star by @tatiana in #1602 * Support ``on_warning_callback`` with ``TestBehavior.BUILD`` and ``ExecutionMode.LOCAL`` by @corsettigyg in #1571 * Fix ``DbtRunLocalOperator.partial()`` support by @tatiana @ashb in #1609 * fix: ``container_name`` is null for ecs integration by @nicor88 in #1592 Docs * Improve MWAA getting-started docs by removing unused imports by @jx2lee in #1562 Others * Disable ``example_cosmos_dbt_build.py`` DAG in CI by @pankajastro in #1567 * Upgrade GitHub Actions Ubuntu version by @tatiana in #1561 * Update GitHub bug issue template by @pankajastro in #1586 * Enable DAG ``example_cosmos_dbt_build.py`` in CI by @pankajastro in #1573 * Run async DAG in DAG without setup/teardown task by @pankajastro in #1599 * Add test case that fully covers recent select issue by @tatiana in #1604 * Add CI job to test multiple dbt versions for the async DAG by @pankajkoti in #1535 * Improve unit tests speed from 89s to 14s by @tatiana in #1600 * Pre-commit updates: #1560, #1583, #1596 Closes: #1550 Mergeable version of #1607 Co-authored-by: Pankaj Singh <98807258+pankajastro@users.noreply.github.com> Co-authored-by: Pankaj Koti <pankajkoti699@gmail.com>
1 task
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
DbtToAirflowConverter can pass dbt_vars to DbtGraph with help of ProjectConfig or operator_args. If operator_args is used in DbtToAirflowConverter then it will lead to the issue with absence of dbt_vars in dbt ls command (faced rendering issue during usage of cosmos with project level variables)
Related Issue(s)
Breaking Change?
No breaking changes
Checklist