Use dbt ls as the default parser when profile_config is provided#1101
Merged
Conversation
✅ Deploy Preview for sunny-pastelito-5ecb04 canceled.
|
tatiana
reviewed
Jul 17, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1101 +/- ##
==========================================
- Coverage 96.50% 96.47% -0.04%
==========================================
Files 64 64
Lines 3288 3288
==========================================
- Hits 3173 3172 -1
- Misses 115 116 +1 ☔ View full report in Codecov by Sentry. |
dosubot
Bot
added
size:XS
pankajastro
force-pushed
the
dbt_ls_as_default_parser
branch
from
3271f4e to
6cc625f
Compare
pankajkoti
changed the title
dbt ls as the default parser when profile_config is provided
pankajkoti
approved these changes
Jul 18, 2024
Contributor
pankajkoti
left a comment
pankajkoti
left a comment
There was a problem hiding this comment.
LGTM, let's wait for @tatiana's review.
tatiana
reviewed
Jul 18, 2024
Collaborator
There was a problem hiding this comment.
@pankajastro Looks great - but, please, let's add a test to cover the use-case that encouraged this change - so we make sure it continues working in the future
pankajastro
force-pushed
the
dbt_ls_as_default_parser
branch
from
6cc625f to
f403292
Compare
tatiana
approved these changes
Jul 19, 2024
Merged
1 task
pankajkoti
added a commit
that referenced
this pull request
Aug 20, 2024
New Features * Add support for loading manifest from cloud stores using Airflow Object Storage by @pankajkoti in #1109 * Cache ``package-lock.yml`` file by @pankajastro in #1086 * Support persisting the ``LoadMode.VIRTUALENV`` directory by @tatiana in #1079 * Add support to store and fetch ``dbt ls`` cache in remote stores by @pankajkoti in #1147 * Add default source nodes rendering by @arojasb3 in #1107 * Add Teradata ``ProfileMapping`` by @sc250072 in #1077 Enhancements * Add ``DatabricksOauthProfileMapping`` profile by @CorsettiS in #1091 * Use ``dbt ls`` as the default parser when ``profile_config`` is provided by @pankajastro in #1101 * Add task owner to dbt operators by @wornjs in #1082 * Extend Cosmos custom selector to support + when using paths and tags by @mvictoria in #1150 * Simplify logging by @dwreeves in #1108 Bug fixes * Fix Teradata ``ProfileMapping`` target invalid issue by @sc250072 in #1088 * Fix empty tag in case of custom parser by @pankajastro in #1100 * Fix ``dbt deps`` of ``LoadMode.DBT_LS`` should use ``ProjectConfig.dbt_vars`` by @tatiana in #1114 * Fix import handling by lazy loading hooks introduced in PR #1109 by @dwreeves in #1132 * Fix Airflow 2.10 regression and add Airflow 2.10 in test matrix by @pankajastro in #1162 Docs * Fix typo in azure-container-instance docs by @pankajastro in #1106 * Use Airflow trademark as it has been registered by @pankajastro in #1105 Others * Run some example DAGs in Kubernetes execution mode in CI by @pankajastro in #1127 * Install requirements.txt by default during dev env spin up by @@CorsettiS in #1099 * Remove ``DbtGraph.current_version`` dead code by @tatiana in #1111 * Disable test for Airflow-2.5 and Python-3.11 combination in CI by @pankajastro in #1124 * Pre-commit hook updates in #1074, #1113, #1125, #1144, #1154, #1167 --------- Co-authored-by: Pankaj Koti <pankajkoti699@gmail.com> Co-authored-by: Pankaj Singh <98807258+pankajastro@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The
load_via_custom_parsermethod is not very effectivewhen it comes to filtering. Currently, if the ExecutionMode
is not Local, we always use load_via_custom_parser to parse
the dbt project. However, I believe it's beneficial to utilize DBT LS
whenever it's available. This PR remove the check if the
execution mode is ExecutionMode.LOCAL before
load_via_dbt_lsRelated Issue(s)
Related: #943
Breaking Change?
I believe no :)
Checklist