Conversation
github-actions
bot
added
proto
SuperFluffy
approved these changes
Jun 3, 2024
Contributor
SuperFluffy
left a comment
SuperFluffy
left a comment
There was a problem hiding this comment.
Good to see this go. Just a comment on best-practices for deprecating proto message fields.
| astria_vendored.tendermint.abci.ValidatorUpdate validator_update_action = 51; | ||
| IbcRelayerChangeAction ibc_relayer_change_action = 52; | ||
| FeeAssetChangeAction fee_asset_change_action = 53; | ||
| MintAction mint_action = 54; |
Contributor
There was a problem hiding this comment.
Hm, if this were a non-alpha protobuf I would make this a 2-step process with 2 PRs:
- first PR: set it as `MintAction mint_action = 54 [deprecated = true];
- second PR:
reserved 54; // deprecated "mint_action".
I think it's ok to not make this a 2-step process because of the alpha-nature. But I think to be on the safe side, can you add a section that reads like this? When we go to v1 (non-alpha) we can remove these.
// deprecated fields
reserved 54; // deprecated "mint_action"
reserved "mint_action";
steezeburger
added a commit
that referenced
this pull request
Jun 5, 2024
* main: fix(charts): conductor configmap fix (#1146) feat(sequencer): add `allowed_fee_asset_ids` abci query and `sequencer_client` support (#1127) chore(conductor): release conductor 0.17 (#1139) feat: use macro to declare metric constants (#1129) refactor(merkle): remove source of panics in audit API (#1137) feat(conductor): skip outdated block metadata (#1120) refactor(sequencer): remove mint module (#1134) feat(bridge-withdrawer): add justfile (#1135) chore(chart): change evm back to latest on dev (#1132) feat(conductor, proto)!: celestia base heights in commitment state (#1121)
github-merge-queue bot
pushed a commit
that referenced
this pull request
Oct 16, 2024
## Summary remove unused enable mint env. We removed the mint module in #1134, the config var was unused but left in.
sgranfield4403-3
added a commit
to sgranfield4403-3/astria
that referenced
this pull request
Oct 2, 2025
## Summary remove unused enable mint env. We removed the mint module in astriaorg/astria#1134, the config var was unused but left in.
AngieD101
added a commit
to AngieD101/astria
that referenced
this pull request
Oct 10, 2025
## Summary remove unused enable mint env. We removed the mint module in astriaorg/astria#1134, the config var was unused but left in.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
remove the mint module and associated types.
Background
we never used it, and not something we want in production anyways.
Changes
Testing
n/a, code was removed
Breaking changes
this removes the mint action, which is technically a breaking change, however it was gated under a feature flag in sequencer which was never enabled on any network afaik. so I don't think this change affects any running network.