feat(sequencer): add allowed_fee_asset_ids abci query and sequencer_client support#1127
Merged
itamarreif merged 18 commits intomainfrom Jun 4, 2024
Merged
Conversation
…quencer-allowed-fee-assets
noot
reviewed
Jun 1, 2024
noot
reviewed
Jun 1, 2024
noot
reviewed
Jun 1, 2024
noot
reviewed
Jun 1, 2024
noot
reviewed
Jun 1, 2024
| ) | ||
| .map_err(|e| { | ||
| Error::abci_query_deserialization( | ||
| "astria.protocol.asset.v1alpha1.AllowedFeeAssetIdsResponse", |
Contributor
There was a problem hiding this comment.
Suggested change
| "astria.protocol.asset.v1alpha1.AllowedFeeAssetIdsResponse", | |
| astria_core::generated::protocol::asset::v1alpha1::AllowedFeeAssetIdsResponse::name(), |
with use prost::Name as _;
noot
reviewed
Jun 1, 2024
noot
approved these changes
Jun 1, 2024
SuperFluffy
approved these changes
Jun 3, 2024
Contributor
SuperFluffy
left a comment
SuperFluffy
left a comment
There was a problem hiding this comment.
Looks good to me. I'd only rethink the naming of the error when constructing the response. It's IMO cleaner to introduce a new bespoke error for every conversion.
crates/astria-core/src/generated/astria.protocol.asset.v1alpha1.rs
Outdated
Show resolved
Hide resolved
…quencer-allowed-fee-assets
…quencer-allowed-fee-assets
steezeburger
added a commit
that referenced
this pull request
Jun 5, 2024
* main: fix(charts): conductor configmap fix (#1146) feat(sequencer): add `allowed_fee_asset_ids` abci query and `sequencer_client` support (#1127) chore(conductor): release conductor 0.17 (#1139) feat: use macro to declare metric constants (#1129) refactor(merkle): remove source of panics in audit API (#1137) feat(conductor): skip outdated block metadata (#1120) refactor(sequencer): remove mint module (#1134) feat(bridge-withdrawer): add justfile (#1135) chore(chart): change evm back to latest on dev (#1132) feat(conductor, proto)!: celestia base heights in commitment state (#1121)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This adds the
allowed_fee_asset_idsABCI info query and the requiredsequencer_clientmethods to use it.Background
This is required for the bridge implementation and other off-chain services to check against local configs on startup.
Changes
FeeAssetsResponsetoprotocolapis/astria/protocol/asset/types.protoastria-core::protocol::asset::queryDenomResponse::into_raw/from_raw(unrelated but this was on the way and took 2 seconds)sequencer client
try_from_rawfailure return a different error kind thanabci_query_deserializationTesting
sequencer-side logic for the abci querysequencer_client