feat(conductor): skip outdated block metadata#1120
Merged
SuperFluffy merged 2 commits intomainfrom Jun 4, 2024
Merged
Conversation
SuperFluffy
requested review from
Fraser999 and
noot
and removed request for
noot
SuperFluffy
changed the title
SuperFluffy
commented
May 29, 2024
|
|
||
| #[must_use] | ||
| pub fn make_sequencer_block(height: u32) -> astria_core::sequencerblock::v1alpha1::SequencerBlock { | ||
| fn repeat_bytes_of_u32_as_array(val: u32) -> [u8; 32] { |
Contributor
Author
There was a problem hiding this comment.
We need a unique block hash for each sequencer height.
joroshiba
approved these changes
Jun 3, 2024
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
noot
reviewed
Jun 3, 2024
Comment on lines
+112
to
+118
| if blob.height().value() < next_expected_firm_sequencer_height { | ||
| info!( | ||
| next_expected_firm_sequencer_height, | ||
| sequencer_height_in_metadata = blob.height().value(), | ||
| "dropping Sequencer metadata item without verifying against Sequencer because its \ | ||
| height is below the next expected firm height" | ||
| ); |
Contributor
There was a problem hiding this comment.
is this guaranteed safe? ie are these blobs already guaranteed to be executed/verified as soft blocks already and we're sure that they are the same as the ones already verified?
Contributor
Author
There was a problem hiding this comment.
Note that this is checking against the next expected firm height - this is independent of the soft blocks.
SuperFluffy
force-pushed
the
superfluffy/skip-known-heights
branch
from
a2fcaab to
c6cb7a6
Compare
steezeburger
added a commit
that referenced
this pull request
Jun 5, 2024
* main: fix(charts): conductor configmap fix (#1146) feat(sequencer): add `allowed_fee_asset_ids` abci query and `sequencer_client` support (#1127) chore(conductor): release conductor 0.17 (#1139) feat: use macro to declare metric constants (#1129) refactor(merkle): remove source of panics in audit API (#1137) feat(conductor): skip outdated block metadata (#1120) refactor(sequencer): remove mint module (#1134) feat(bridge-withdrawer): add justfile (#1135) chore(chart): change evm back to latest on dev (#1132) feat(conductor, proto)!: celestia base heights in commitment state (#1121)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Conductor drops sequencer metadata items retrieved from Celestia if their height has already been executed/committed.
Background
Conductor would try and unnecessarily verify Sequencer metadata retrieved from Celestia, putting a lot of pressure on the Sequencer node. Because Conductor is stateless, it fetches all Celestia blobs for the sequencer and rollup namespaces starting from the
celestia_base_block_heightconfigured the rollup. It would then verify all sequencer metadata items retrieved in this way against the Sequencer, even if the metadata was for old blocks (meaning blocks with a height below the next firm height expected by the rollup).Changes
Testing