Omit the nav bar title when it has no use #5316
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zanieb
added
documentation
zanieb
changed the title
|
A little hesitant on the trade-off here (compared to something more impactful like #5310) |
zanieb
force-pushed
the
zb/docs-nav-title
branch
from
ac773ed
to
5a17aa7
Compare
This comment was marked as outdated.
This comment was marked as outdated.
zanieb
added a commit
that referenced
this pull request
Jul 23, 2024
Fixes blur noted in #5316 but doesn't drop the title entirely. #5316 is my preferred design, if the implementation was cost-free. <img width="1259" alt="Screenshot 2024-07-23 at 3 53 48 PM" src="https://github.com/user-attachments/assets/6f9b828b-884f-447d-8508-ba4023152e2f"> (nothing to see at the rest of the breakpoints >1220) <img width="1259" alt="Screenshot 2024-07-23 at 3 53 56 PM" src="https://github.com/user-attachments/assets/b892cd76-cd91-4e78-b8c8-58e16a8b1130">
|
With #5628 I feel like this is even more relevant. |
charliermarsh
approved these changes
Jul 31, 2024
zanieb
force-pushed
the
zb/docs-nav-title
branch
from
5a17aa7
to
f1a7314
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Turns out this is needed for navigation on mobile, but useless on larger screens.
Closes #5130