Reduce spacing between nav items #5310
Conversation
zanieb
added
documentation
|
This gets us 6 more items above the fold. |
|
|
||
| .md-nav--secondary .md-nav__link { | ||
| margin-top: 0.5em; | ||
| } |
There was a problem hiding this comment.
I'll admit that I'm hesitant to add stuff like this for a few reasons: (1) we need to test it against all responsive breakpoints, not just on desktop; (2) it's not robust to updates to MkDocs or Material for MkDocs (what if they change the styling, or even the class names -- we'd have no way of knowing that this broke other than visual inspection).
There was a problem hiding this comment.
I understand the concern, but the default navigation is going to be a problem. I'm not sure what to suggest as an alternative.
There was a problem hiding this comment.
Ok. There is a very good chance that this will silently break at some point. But I think you hear me.
At the very least, could I request that you: (1) add comments to each change in the CSS, and (2) add screenshots for all breakpoints?
There was a problem hiding this comment.
I definitely hear you. I'm happy to take an alternative approach if there is one. Otherwise, I think this is (1) not a huge deal if there's a regression, though I could see how changes could interact badly if / when we have more custom CSS (2) a temporary solution until we revisit documentation rendering as a whole.
There was a problem hiding this comment.
(Sent a DM about the breakpoints)
| } | ||
|
|
||
| .md-nav--secondary .md-nav__link { | ||
| margin-top: 0.5em; |
There was a problem hiding this comment.
Note this specific change was to prevent the right-side TOC from also being condensed.
|
|
Dropped #5130 from here — it's more complicated. The useless "uv" title on the navbar remains. |
Before
After
