Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix blurring from nav title box shadow #5374

Merged
merged 1 commit into from
Jul 23, 2024
Merged

Fix blurring from nav title box shadow #5374

merged 1 commit into from
Jul 23, 2024

Conversation

zanieb
Copy link
Member

@zanieb zanieb commented Jul 23, 2024

Fixes blur noted in #5316 but doesn't drop the title entirely. #5316 is my preferred design, if the implementation was cost-free.

Screenshot 2024-07-23 at 3 53 48 PM

(nothing to see at the rest of the breakpoints >1220)

Screenshot 2024-07-23 at 3 53 56 PM

@zanieb zanieb added documentation Improvements or additions to documentation preview Experimental behavior labels Jul 23, 2024
Copy link
Member

@charliermarsh charliermarsh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it'd be helpful to include one "Before" pic so we can have a "Before" vs. "After". As-is, it's a little hard for me to know what the effect was as the reviewer.

@zanieb
Copy link
Member Author

zanieb commented Jul 23, 2024

Sorry still trying to figure out how to present all the breakpoints as well as the key change.

The "before" image is at #5316 (comment)

Screenshot 2024-07-23 at 5 33 18 PM

Here's the "after":

Screenshot 2024-07-23 at 5 32 50 PM

@zanieb zanieb merged commit 3822a43 into main Jul 23, 2024
45 checks passed
@zanieb zanieb deleted the zb/nav-shadow branch July 23, 2024 22:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation preview Experimental behavior
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants