Skip to content

Always target manylinux 2_17 and better pre-upload checks#2393

Merged
MichaReiser merged 3 commits intomainfrom
konsti/manylinux_2_17
Jan 16, 2026
Merged

Always target manylinux 2_17 and better pre-upload checks#2393
MichaReiser merged 3 commits intomainfrom
konsti/manylinux_2_17

Conversation

@konstin
Copy link
Member

@konstin konstin commented Jan 8, 2026

We currently build for manylinux_2_17, and if this target changes, it should be an intentional, explicit change.

Closes #2389
Closes #2396

@konstin konstin force-pushed the konsti/manylinux_2_17 branch from 0671b4b to a8ca2fe Compare January 8, 2026 08:58
@konstin
Copy link
Member Author

konstin commented Jan 8, 2026

@konstin konstin added the internal An internal refactor or improvement label Jan 8, 2026
konstin added a commit to astral-sh/uv that referenced this pull request Jan 8, 2026
This ensures that changes to the targets are intentional and explicit.

The target versions are from https://pypi.org/project/uv/0.9.22/#files

See also astral-sh/ty#2393
@konstin konstin force-pushed the konsti/manylinux_2_17 branch 2 times, most recently from 933d732 to 1399e82 Compare January 8, 2026 10:17
We currently build for manylinux_2_17, and if this target changes, it should be an intentional, explicit change.
@konstin konstin force-pushed the konsti/manylinux_2_17 branch from 1399e82 to a8fdb7e Compare January 8, 2026 11:00
@MichaReiser
Copy link
Member

MichaReiser commented Jan 8, 2026

I assume this requires the upstream maturin fix first or is the build failing for another reason?

@konstin
Copy link
Member Author

konstin commented Jan 8, 2026

Yep, on it: PyO3/maturin#2926

konstin added a commit to astral-sh/uv that referenced this pull request Jan 8, 2026
This ensures that changes to the targets are intentional and explicit, and PyPI compatibility is checked by maturin.

The target versions are from https://pypi.org/project/uv/0.9.22/#files

See also astral-sh/ty#2393
konstin added a commit to astral-sh/uv that referenced this pull request Jan 9, 2026
This ensures that changes to the targets are intentional and explicit, and PyPI compatibility is checked by maturin.

The target versions are from https://pypi.org/project/uv/0.9.22/#files

See also astral-sh/ty#2393
konstin added a commit to astral-sh/uv that referenced this pull request Jan 9, 2026
This ensures that changes to the targets are intentional and explicit, and PyPI compatibility is checked by maturin.

The target versions are from https://pypi.org/project/uv/0.9.22/#files

See also astral-sh/ty#2393
@konstin konstin changed the title Always target manylinux_2_17 Always target manylinux 2_17 and better pre-upload checks Jan 9, 2026
@konstin konstin marked this pull request as draft January 9, 2026 12:05
konstin added a commit to astral-sh/ruff that referenced this pull request Jan 9, 2026
This ensures that changes to the targets are intentional and explicit.

See also astral-sh/ty#2393
and astral-sh/uv#17358
konstin added a commit to astral-sh/uv that referenced this pull request Jan 12, 2026
This ensures that changes to the targets are intentional and explicit, and PyPI compatibility is checked by maturin.

The target versions are from https://pypi.org/project/uv/0.9.22/#files

See also astral-sh/ty#2393
konstin added a commit to astral-sh/uv that referenced this pull request Jan 14, 2026
This ensures that changes to the targets are intentional and explicit, and PyPI compatibility is checked by maturin.

The target versions are from https://pypi.org/project/uv/0.9.22/#files

See also astral-sh/ty#2393
konstin added a commit to astral-sh/uv that referenced this pull request Jan 15, 2026
This ensures that changes to the targets are intentional and explicit, and PyPI compatibility is checked by maturin.

The target versions are from https://pypi.org/project/uv/0.9.22/#files

See also astral-sh/ty#2393
konstin added a commit to astral-sh/uv that referenced this pull request Jan 15, 2026
…#17358)

This ensures that changes to the targets are intentional and explicit.

The target versions are from https://pypi.org/project/uv/0.9.22/#files

See also astral-sh/ty#2393
@konstin
Copy link
Member Author

konstin commented Jan 16, 2026

I've verified these changes with testpypi: https://test.pypi.org/project/ty-konsti-test/#files

I'll leave merging to the person who makes the release.

@konstin konstin marked this pull request as ready for review January 16, 2026 09:05
@MichaReiser MichaReiser reopened this Jan 16, 2026
@MichaReiser
Copy link
Member

I'll leave merging to the person who makes the release.

I don't know who that will be, but happy to take the blame :sweat

Thank you

@MichaReiser MichaReiser enabled auto-merge (squash) January 16, 2026 09:56
@MichaReiser MichaReiser merged commit 9569569 into main Jan 16, 2026
60 checks passed
@MichaReiser MichaReiser deleted the konsti/manylinux_2_17 branch January 16, 2026 09:58
ntBre pushed a commit to astral-sh/ruff that referenced this pull request Jan 16, 2026
…#22477)

This ensures that changes to the targets are intentional and explicit.

See also astral-sh/ty#2393 and
astral-sh/uv#17358
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

internal An internal refactor or improvement

Projects

None yet

Development

Successfully merging this pull request may close these issues.

manylinux 2.17 wheels are missing on pypi for 0.10.0

2 participants