Skip to content

Comments

Use explicit manylinux/musllinux targets and better pre-upload checks#17358

Merged
konstin merged 1 commit intomainfrom
konsti/explicit-manylinux
Jan 15, 2026
Merged

Use explicit manylinux/musllinux targets and better pre-upload checks#17358
konstin merged 1 commit intomainfrom
konsti/explicit-manylinux

Conversation

@konstin
Copy link
Member

@konstin konstin commented Jan 8, 2026

This ensures that changes to the targets are intentional and explicit.

The target versions are from https://pypi.org/project/uv/0.9.22/#files

See also astral-sh/ty#2393

@konstin konstin added the internal A refactor or improvement that is not user-facing label Jan 8, 2026
@konstin konstin changed the title Use explicit manylinux/musllinux target Use explicit manylinux/musllinux targets Jan 8, 2026
@konstin
Copy link
Member Author

konstin commented Jan 8, 2026

@konstin konstin temporarily deployed to uv-test-registries January 8, 2026 10:06 — with GitHub Actions Inactive
@konstin konstin marked this pull request as draft January 8, 2026 10:59
@konstin konstin force-pushed the konsti/explicit-manylinux branch from 563f50d to 7562fd7 Compare January 8, 2026 16:23
@konstin konstin temporarily deployed to uv-test-registries January 8, 2026 16:25 — with GitHub Actions Inactive
@konstin konstin force-pushed the konsti/explicit-manylinux branch from 7562fd7 to 03b420c Compare January 9, 2026 11:28
@konstin konstin temporarily deployed to uv-test-registries January 9, 2026 11:29 — with GitHub Actions Inactive
@konstin konstin force-pushed the konsti/explicit-manylinux branch from 03b420c to 3923644 Compare January 9, 2026 11:34
@konstin konstin temporarily deployed to uv-test-registries January 9, 2026 11:35 — with GitHub Actions Inactive
@konstin konstin temporarily deployed to uv-test-registries January 9, 2026 11:49 — with GitHub Actions Inactive
@konstin konstin temporarily deployed to uv-test-registries January 9, 2026 11:58 — with GitHub Actions Inactive
@konstin konstin changed the title Use explicit manylinux/musllinux targets Use explicit manylinux/musllinux targets and better pre-upload checks Jan 9, 2026
@konstin konstin marked this pull request as ready for review January 9, 2026 12:35
konstin added a commit to astral-sh/ruff that referenced this pull request Jan 9, 2026
This ensures that changes to the targets are intentional and explicit.

See also astral-sh/ty#2393
and astral-sh/uv#17358
@konstin konstin requested a review from zanieb January 9, 2026 12:49
@zanieb
Copy link
Member

zanieb commented Jan 9, 2026

Is it intentional to also upgrade maturin here?

@konstin
Copy link
Member Author

konstin commented Jan 9, 2026

Yes, we need the new version for the better checks (--compatibility pypi with manylinux: )

@konstin konstin force-pushed the konsti/explicit-manylinux branch from 7e1fab5 to df5c3d7 Compare January 12, 2026 18:37
@konstin konstin temporarily deployed to uv-test-registries January 12, 2026 18:42 — with GitHub Actions Inactive
@konstin konstin force-pushed the konsti/explicit-manylinux branch from df5c3d7 to 581c94e Compare January 14, 2026 09:07
@konstin konstin temporarily deployed to uv-test-registries January 14, 2026 09:10 — with GitHub Actions Inactive
This ensures that changes to the targets are intentional and explicit, and PyPI compatibility is checked by maturin.

The target versions are from https://pypi.org/project/uv/0.9.22/#files

See also astral-sh/ty#2393
@konstin konstin force-pushed the konsti/explicit-manylinux branch from 581c94e to ac76383 Compare January 15, 2026 12:59
@konstin
Copy link
Member Author

konstin commented Jan 15, 2026

A test upload with testpypi (and renamed packages) passed, this verifies that the produced tags are accepted by PyPI.

@konstin konstin merged commit 157ac88 into main Jan 15, 2026
67 checks passed
@konstin konstin deleted the konsti/explicit-manylinux branch January 15, 2026 14:01
ntBre pushed a commit to astral-sh/ruff that referenced this pull request Jan 16, 2026
…#22477)

This ensures that changes to the targets are intentional and explicit.

See also astral-sh/ty#2393 and
astral-sh/uv#17358
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

internal A refactor or improvement that is not user-facing

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants