Support armv6l and armv7l in pypi compatibility#2926
Merged
Conversation
While pypi generally requires manylinux or musllinux tags, it also accepts `linux_armv6l` and `linux_armv7l` wheels (for historic reasons?): https://github.com/pypi/warehouse/blob/556e1e3390999381c382873b003a779a1363cb4d/warehouse/forklift/legacy.py#L122-L123 Test plan: The script below passes without warnings ``` # armv6l rustup target add arm-unknown-linux-gnueabihf rustup target add arm-unknown-linux-musleabihf # armv7l rustup target add armv7-unknown-linux-gnueabihf rustup target add armv7-unknown-linux-musleabihf # pyo3 cargo run -q -- build --manifest-path test-crates/pyo3-pure/Cargo.toml --zig -i python3 --compatibility pypi --target arm-unknown-linux-gnueabihf cargo run -q -- build --manifest-path test-crates/pyo3-pure/Cargo.toml --zig -i python3 --compatibility pypi --target arm-unknown-linux-musleabihf cargo run -q -- build --manifest-path test-crates/pyo3-pure/Cargo.toml --zig -i python3 --compatibility pypi --target armv7-unknown-linux-gnueabihf cargo run -q -- build --manifest-path test-crates/pyo3-pure/Cargo.toml --zig -i python3 --compatibility pypi --target armv7-unknown-linux-musleabihf # binary cargo run -q -- build --manifest-path test-crates/hello-world/Cargo.toml --zig -i python3 --compatibility pypi --target arm-unknown-linux-gnueabihf cargo run -q -- build --manifest-path test-crates/hello-world/Cargo.toml --zig -i python3 --compatibility pypi --target arm-unknown-linux-musleabihf cargo run -q -- build --manifest-path test-crates/hello-world/Cargo.toml --zig -i python3 --compatibility pypi --target armv7-unknown-linux-gnueabihf cargo run -q -- build --manifest-path test-crates/hello-world/Cargo.toml --zig -i python3 --compatibility pypi --target armv7-unknown-linux-musleabihf ```
konstin
added a commit
to konstin/maturin
that referenced
this pull request
Jan 8, 2026
While pypi generally requires manylinux or musllinux tags, it also accepts `linux_armv6l` and `linux_armv7l` wheels (for historic reasons?): https://github.com/pypi/warehouse/blob/556e1e3390999381c382873b003a779a1363cb4d/warehouse/forklift/legacy.py#L122-L123 This PR fixes the support for `--compatibility pypi` with these targets. Test plan: The script below passes without warnings ``` # armv6l rustup target add arm-unknown-linux-gnueabihf rustup target add arm-unknown-linux-musleabihf # armv7l rustup target add armv7-unknown-linux-gnueabihf rustup target add armv7-unknown-linux-musleabihf # pyo3 cargo run -q -- build --manifest-path test-crates/pyo3-pure/Cargo.toml --zig -i python3 --compatibility pypi --target arm-unknown-linux-gnueabihf cargo run -q -- build --manifest-path test-crates/pyo3-pure/Cargo.toml --zig -i python3 --compatibility pypi --target arm-unknown-linux-musleabihf cargo run -q -- build --manifest-path test-crates/pyo3-pure/Cargo.toml --zig -i python3 --compatibility pypi --target armv7-unknown-linux-gnueabihf cargo run -q -- build --manifest-path test-crates/pyo3-pure/Cargo.toml --zig -i python3 --compatibility pypi --target armv7-unknown-linux-musleabihf # binary cargo run -q -- build --manifest-path test-crates/hello-world/Cargo.toml --zig -i python3 --compatibility pypi --target arm-unknown-linux-gnueabihf cargo run -q -- build --manifest-path test-crates/hello-world/Cargo.toml --zig -i python3 --compatibility pypi --target arm-unknown-linux-musleabihf cargo run -q -- build --manifest-path test-crates/hello-world/Cargo.toml --zig -i python3 --compatibility pypi --target armv7-unknown-linux-gnueabihf cargo run -q -- build --manifest-path test-crates/hello-world/Cargo.toml --zig -i python3 --compatibility pypi --target armv7-unknown-linux-musleabihf ```
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While pypi generally requires manylinux or musllinux tags, it also accepts
linux_armv6landlinux_armv7lwheels (for historic reasons?):https://github.com/pypi/warehouse/blob/556e1e3390999381c382873b003a779a1363cb4d/warehouse/forklift/legacy.py#L122-L123
This PR fixes the support for
--compatibility pypiwith these targets.Test plan: The script below passes without warnings