Skip to content

fix: add camera permissions setup for android#4560

Merged
pvinis merged 2 commits intomasterfrom
brian/consignments-android-photos-followup
Mar 29, 2021
Merged

fix: add camera permissions setup for android#4560
pvinis merged 2 commits intomasterfrom
brian/consignments-android-photos-followup

Conversation

@brainbicycle
Copy link
Contributor

@brainbicycle brainbicycle commented Mar 25, 2021

The type of this PR is: fix

This PR resolves CX-1154

Description

Follow-up to #4535 which worked for selecting from library but missed some necessary permissions for using camera on Android.

Adds some camera permissions to the android manifest as per setup instructions here:
https://github.com/ivpusic/react-native-image-crop-picker#android

Screenshots

takePic.mp4

PR Checklist (tick all before merging)

  • I have included screenshots or videos to illustrate my changes, or I have not changed anything that impacts the UI.
  • I have added tests for my changes, or my changes don't require testing, or I have included a link to a separate Jira ticket covering the tests.
  • I have documented any follow-up work that this PR will require, or it does not require any.
  • I have added an app state migration, or my changes do not require one. (What are migrations?)
  • I have added a CHANGELOG.yml entry or my changes do not require one.

Copy link
Contributor

@ds300 ds300 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙌🏼

@pvinis pvinis merged commit f433558 into master Mar 29, 2021
@pvinis pvinis deleted the brian/consignments-android-photos-followup branch March 29, 2021 09:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants