Skip to content

fix: add camera permissions setup for android #4560

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
pvinis merged 2 commits into from
Mar 29, 2021
Merged

fix: add camera permissions setup for android #4560

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c8f6674
add camera permissions setup for android
brainbicycle Mar 25, 2021
a626bd8
update changelog
brainbicycle Mar 25, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,7 @@ upcoming:
- Add link interception for react web views - david
- Fix iOS modal presentation infra code - david
- Enable sentry for android - brian, barry
- Add camera permissions to android manifest - brian
user_facing:
- Set system navigation bar color to white on modals for android - mounir
- Fix UI for Inquiry message count on iPad - pavlos
Expand Down
1 change: 1 addition & 0 deletions android/app/build.gradle
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -141,6 +141,7 @@ android {
targetSdkVersion rootProject.ext.targetSdkVersion
versionCode 7
versionName "1.0.0"
vectorDrawables.useSupportLibrary = true

multiDexEnabled true

Expand Down
3 changes: 3 additions & 0 deletions android/app/src/main/AndroidManifest.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,9 @@
package="net.artsy.app">

<uses-permission android:name="android.permission.INTERNET" />
<uses-permission android:name="android.permission.CAMERA" />
<uses-feature android:name="android.hardware.camera" android:required="false" />
<uses-feature android:name="android.hardware.camera.front" android:required="false" />

<application
android:name=".MainApplication"
Expand Down