Skip to content

chore: bump gitops engine + remove IterateHierarchyv1#23924

Merged
crenshaw-dev merged 6 commits intoargoproj:masterfrom
pjiang-dev:pjiang/bumpgitops
Jul 25, 2025
Merged

chore: bump gitops engine + remove IterateHierarchyv1#23924
crenshaw-dev merged 6 commits intoargoproj:masterfrom
pjiang-dev:pjiang/bumpgitops

Conversation

@pjiang-dev
Copy link
Contributor

@pjiang-dev pjiang-dev commented Jul 24, 2025

Checklist:

  • Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this does not need to be in the release notes.
  • The title of the PR states what changed and the related issues number (used for the release note).
  • The title of the PR conforms to the Toolchain Guide
  • I've included "Closes [ISSUE #]" or "Fixes [ISSUE #]" in the description to automatically close the associated issue.
  • I've updated both the CLI and UI to expose my feature, or I plan to submit a second PR with them.
  • Does this PR require documentation updates?
  • I've updated documentation as required by this PR.
  • I have signed off all my commits as required by DCO
  • I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
  • My build is green (troubleshooting builds).
  • My new feature complies with the feature status guidelines.
  • I have added a brief description of why this PR is necessary and/or what this PR solves.
  • Optional. My organization is added to USERS.md.
  • Optional. For bug fixes, I've indicated what older releases this fix should be cherry-picked into (this may or may not happen depending on risk/complexity).

@pjiang-dev pjiang-dev requested a review from a team as a code owner July 24, 2025 17:30
@bunnyshell
Copy link

bunnyshell bot commented Jul 24, 2025

❌ Preview Environment deleted from Bunnyshell

Available commands (reply to this comment):

  • 🚀 /bns:deploy to deploy the environment

@pjiang-dev
Copy link
Contributor Author

@andrii-korotkov The build is failing due to

#39 107.6 # github.com/argoproj/argo-cd/v3/controller/cache
Error: #39 107.6 controller/cache/cache.go:677:14: clusterInfo.IterateHierarchy undefined (type "github.com/argoproj/gitops-engine/pkg/cache".ClusterCache has no field or method IterateHierarchy)

I see you made a related PR to remove this IterateHierarchy in argoproj/gitops-engine#748

Is this something you're still working on ? As i have a gitops-engine change which now includes this change

@andrii-korotkov
Copy link
Contributor

andrii-korotkov commented Jul 24, 2025 via email

@pjiang-dev
Copy link
Contributor Author

I'll include the change to remove IterateHierachyv1 and codegen in this PR then.

@pjiang-dev pjiang-dev changed the title chore: bump gitops engine chore: bump gitops engine + remove Iteratehierarchyv1 Jul 24, 2025
@pjiang-dev pjiang-dev changed the title chore: bump gitops engine + remove Iteratehierarchyv1 chore: bump gitops engine + remove IterateHierarchyv1 Jul 24, 2025
@codecov
Copy link

codecov bot commented Jul 24, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 60.19%. Comparing base (be2c243) to head (7d59394).
⚠️ Report is 789 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master   #23924      +/-   ##
==========================================
+ Coverage   60.16%   60.19%   +0.03%     
==========================================
  Files         346      346              
  Lines       59277    59268       -9     
==========================================
+ Hits        35663    35678      +15     
+ Misses      20755    20726      -29     
- Partials     2859     2864       +5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: Peter Jiang <peterjiang823@gmail.com>
Signed-off-by: Peter Jiang <peterjiang823@gmail.com>
Signed-off-by: Peter Jiang <peterjiang823@gmail.com>
if err != nil {
return err
}
clusterInfo.IterateHierarchy(key, func(resource *clustercache.Resource, namespaceResources map[kube.ResourceKey]*clustercache.Resource) bool {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wanna go ahead and either delete the calling method or at least mark it as deprecated? There are no callers in Argo CD, and I really doubt anyone is using this method as library code.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yea lets just delete it then if there are no references

Signed-off-by: Peter Jiang <peterjiang823@gmail.com>
Signed-off-by: Peter Jiang <peterjiang823@gmail.com>
Signed-off-by: Peter Jiang <peterjiang823@gmail.com>
@crenshaw-dev crenshaw-dev merged commit 660295f into argoproj:master Jul 25, 2025
28 checks passed
enneitex pushed a commit to enneitex/argo-cd that referenced this pull request Aug 24, 2025
Signed-off-by: Peter Jiang <peterjiang823@gmail.com>
Signed-off-by: enneitex <etienne.divet@gmail.com>
downfa11 pushed a commit to downfa11/argo-cd that referenced this pull request Aug 25, 2025
Signed-off-by: Peter Jiang <peterjiang823@gmail.com>
Mangaal pushed a commit to Mangaal/argo-cd that referenced this pull request Sep 10, 2025
Signed-off-by: Peter Jiang <peterjiang823@gmail.com>
Signed-off-by: Mangaal <angommeeteimangaal@gmail.com>
downfa11 pushed a commit to downfa11/argo-cd that referenced this pull request Sep 12, 2025
Signed-off-by: Peter Jiang <peterjiang823@gmail.com>
sivasath16 pushed a commit to sivasath16/argo-cd that referenced this pull request Sep 17, 2025
Signed-off-by: Peter Jiang <peterjiang823@gmail.com>
sivasath16 pushed a commit to sivasath16/argo-cd that referenced this pull request Sep 17, 2025
Signed-off-by: Peter Jiang <peterjiang823@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants