chore: bump gitops engine + remove IterateHierarchyv1#23924
chore: bump gitops engine + remove IterateHierarchyv1#23924crenshaw-dev merged 6 commits intoargoproj:masterfrom
Conversation
❌ Preview Environment deleted from BunnyshellAvailable commands (reply to this comment):
|
|
@andrii-korotkov The build is failing due to I see you made a related PR to remove this Is this something you're still working on ? As i have a gitops-engine change which now includes this change |
|
Sorry, I didn’t submit a follow-up pr yet. I think you should be able to
resolve it by just running codegen.
…On Thu, Jul 24, 2025 at 10:49 AM Peter Jiang ***@***.***> wrote:
*pjiang-dev* left a comment (argoproj/argo-cd#23924)
<#23924 (comment)>
@andrii-korotkov <https://github.com/andrii-korotkov> The build is
failing due to
#39 107.6 # github.com/argoproj/argo-cd/v3/controller/cache
Error: #39 107.6 controller/cache/cache.go:677:14: clusterInfo.IterateHierarchy undefined (type "github.com/argoproj/gitops-engine/pkg/cache".ClusterCache has no field or method IterateHierarchy)
I see you made a related PR to remove this IterateHierarchy in
argoproj/gitops-engine#748
<argoproj/gitops-engine#748>
Is this something you're still working on ? As i have a gitops-engine
change which now includes this change
—
Reply to this email directly, view it on GitHub
<#23924 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AA2VCNV7U22GJX7QEYU24YL3KEMCJAVCNFSM6AAAAACCJPS7OCVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZTCMJUGMZTEMJSGY>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
|
I'll include the change to remove IterateHierachyv1 and codegen in this PR then. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #23924 +/- ##
==========================================
+ Coverage 60.16% 60.19% +0.03%
==========================================
Files 346 346
Lines 59277 59268 -9
==========================================
+ Hits 35663 35678 +15
+ Misses 20755 20726 -29
- Partials 2859 2864 +5 ☔ View full report in Codecov by Sentry. |
Signed-off-by: Peter Jiang <peterjiang823@gmail.com>
Signed-off-by: Peter Jiang <peterjiang823@gmail.com>
Signed-off-by: Peter Jiang <peterjiang823@gmail.com>
2793073 to
dc393ec
Compare
| if err != nil { | ||
| return err | ||
| } | ||
| clusterInfo.IterateHierarchy(key, func(resource *clustercache.Resource, namespaceResources map[kube.ResourceKey]*clustercache.Resource) bool { |
There was a problem hiding this comment.
Wanna go ahead and either delete the calling method or at least mark it as deprecated? There are no callers in Argo CD, and I really doubt anyone is using this method as library code.
There was a problem hiding this comment.
yea lets just delete it then if there are no references
Signed-off-by: Peter Jiang <peterjiang823@gmail.com>
Signed-off-by: Peter Jiang <peterjiang823@gmail.com>
Signed-off-by: Peter Jiang <peterjiang823@gmail.com>
Signed-off-by: Peter Jiang <peterjiang823@gmail.com> Signed-off-by: enneitex <etienne.divet@gmail.com>
Signed-off-by: Peter Jiang <peterjiang823@gmail.com>
Signed-off-by: Peter Jiang <peterjiang823@gmail.com> Signed-off-by: Mangaal <angommeeteimangaal@gmail.com>
Signed-off-by: Peter Jiang <peterjiang823@gmail.com>
Signed-off-by: Peter Jiang <peterjiang823@gmail.com>
Signed-off-by: Peter Jiang <peterjiang823@gmail.com>
Checklist: