Skip to content

fix(appcontroller): selfhealattemptscount needs to be reset at times#22095

Merged
ishitasequeira merged 1 commit intoargoproj:masterfrom
blakepettersson:fix/reset-self-heal-counter
Mar 2, 2025
Merged

fix(appcontroller): selfhealattemptscount needs to be reset at times#22095
ishitasequeira merged 1 commit intoargoproj:masterfrom
blakepettersson:fix/reset-self-heal-counter

Conversation

@blakepettersson
Copy link
Copy Markdown
Member

SelfHealAttemptsCount should be reset when either a new revision is available or if the same revision has previously successfully synced. Fixes #21599.

Checklist:

  • Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this does not need to be in the release notes.
  • The title of the PR states what changed and the related issues number (used for the release note).
  • The title of the PR conforms to the Toolchain Guide
  • I've included "Closes [ISSUE #]" or "Fixes [ISSUE #]" in the description to automatically close the associated issue.
  • I've updated both the CLI and UI to expose my feature, or I plan to submit a second PR with them.
  • Does this PR require documentation updates?
  • I've updated documentation as required by this PR.
  • I have signed off all my commits as required by DCO
  • I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
  • My build is green (troubleshooting builds).
  • My new feature complies with the feature status guidelines.
  • I have added a brief description of why this PR is necessary and/or what this PR solves.
  • Optional. My organization is added to USERS.md.
  • Optional. For bug fixes, I've indicated what older releases this fix should be cherry-picked into (this may or may not happen depending on risk/complexity).

`SelfHealAttemptsCount` should be reset when either a new revision is
available or if the same revision has previously successfully synced.
Fixes argoproj#21599.

Signed-off-by: Blake Pettersson <blake.pettersson@gmail.com>
@blakepettersson blakepettersson requested a review from a team as a code owner February 28, 2025 21:18
@bunnyshell
Copy link
Copy Markdown

bunnyshell bot commented Feb 28, 2025

❌ Preview Environment deleted from Bunnyshell

Available commands (reply to this comment):

  • 🚀 /bns:deploy to deploy the environment

@codecov
Copy link
Copy Markdown

codecov bot commented Feb 28, 2025

Codecov Report

Attention: Patch coverage is 79.16667% with 5 lines in your changes missing coverage. Please review.

Project coverage is 55.84%. Comparing base (a1431be) to head (494741c).
Report is 495 commits behind head on master.

Files with missing lines Patch % Lines
controller/appcontroller.go 79.16% 4 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master   #22095      +/-   ##
==========================================
+ Coverage   55.75%   55.84%   +0.09%     
==========================================
  Files         341      342       +1     
  Lines       57004    57148     +144     
==========================================
+ Hits        31780    31917     +137     
- Misses      22590    22605      +15     
+ Partials     2634     2626       -8     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@andrii-korotkov-verkada andrii-korotkov-verkada added the ready-for-review An approver should give a final review and merge the PR label Mar 1, 2025
@github-project-automation github-project-automation bot moved this to Ready for final review in Argo CD Review Mar 1, 2025
Copy link
Copy Markdown
Member

@ishitasequeira ishitasequeira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!!

@ishitasequeira ishitasequeira merged commit e6f94f2 into argoproj:master Mar 2, 2025
32 checks passed
chzar pushed a commit to chzar/argo-cd that referenced this pull request Mar 3, 2025
…rgoproj#22095)

Signed-off-by: Blake Pettersson <blake.pettersson@gmail.com>
kingbj940429 pushed a commit to kingbj940429/argo-cd that referenced this pull request Mar 4, 2025
…rgoproj#22095)

Signed-off-by: Blake Pettersson <blake.pettersson@gmail.com>
Signed-off-by: kingbj0429 <kingbj0429@lunit.io>
kahou82 pushed a commit to kahou82/argo-cd that referenced this pull request Mar 9, 2025
…rgoproj#22095)

Signed-off-by: Blake Pettersson <blake.pettersson@gmail.com>
Signed-off-by: Kahou Lei <kahou82@gmail.com>
@blakepettersson blakepettersson deleted the fix/reset-self-heal-counter branch April 2, 2025 23:20
Aaron-9900 pushed a commit to Aaron-9900/argo-cd that referenced this pull request Apr 7, 2025
…rgoproj#22095)

Signed-off-by: Blake Pettersson <blake.pettersson@gmail.com>
Aaron-9900 pushed a commit to Aaron-9900/argo-cd that referenced this pull request Apr 7, 2025
…rgoproj#22095)

Signed-off-by: Blake Pettersson <blake.pettersson@gmail.com>
Aaron-9900 pushed a commit to Aaron-9900/argo-cd that referenced this pull request Apr 7, 2025
…rgoproj#22095)

Signed-off-by: Blake Pettersson <blake.pettersson@gmail.com>
Aaron-9900 pushed a commit to Aaron-9900/argo-cd that referenced this pull request Apr 7, 2025
…rgoproj#22095)

Signed-off-by: Blake Pettersson <blake.pettersson@gmail.com>
rumstead pushed a commit that referenced this pull request Apr 7, 2025
…22095, #20978) (#22583)

Signed-off-by: Michal Ryšavý <michal.rysavy@ext.csas.cz>
Signed-off-by: Blake Pettersson <blake.pettersson@gmail.com>
Co-authored-by: Michal Ryšavý <mrysavy@users.noreply.github.com>
Co-authored-by: Michal Ryšavý <michal.rysavy@ext.csas.cz>
Co-authored-by: Blake Pettersson <blake.pettersson@gmail.com>
Hapshanko pushed a commit to Hapshanko/argo-cd that referenced this pull request Apr 29, 2025
…rgoproj#22095)

Signed-off-by: Blake Pettersson <blake.pettersson@gmail.com>
Signed-off-by: Hapshanko <adamgaming391100@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready-for-review An approver should give a final review and merge the PR

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

SelfHealAttemptsCount not resetting if application syncs successfully/on new revision

3 participants