fix(appcontroller): selfhealattemptscount needs to be reset at times#22095
Merged
ishitasequeira merged 1 commit intoargoproj:masterfrom Mar 2, 2025
Merged
Conversation
`SelfHealAttemptsCount` should be reset when either a new revision is available or if the same revision has previously successfully synced. Fixes argoproj#21599. Signed-off-by: Blake Pettersson <blake.pettersson@gmail.com>
❌ Preview Environment deleted from BunnyshellAvailable commands (reply to this comment):
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #22095 +/- ##
==========================================
+ Coverage 55.75% 55.84% +0.09%
==========================================
Files 341 342 +1
Lines 57004 57148 +144
==========================================
+ Hits 31780 31917 +137
- Misses 22590 22605 +15
+ Partials 2634 2626 -8 ☔ View full report in Codecov by Sentry. |
andrii-korotkov-verkada
approved these changes
Mar 1, 2025
chzar
pushed a commit
to chzar/argo-cd
that referenced
this pull request
Mar 3, 2025
…rgoproj#22095) Signed-off-by: Blake Pettersson <blake.pettersson@gmail.com>
kingbj940429
pushed a commit
to kingbj940429/argo-cd
that referenced
this pull request
Mar 4, 2025
…rgoproj#22095) Signed-off-by: Blake Pettersson <blake.pettersson@gmail.com> Signed-off-by: kingbj0429 <kingbj0429@lunit.io>
kahou82
pushed a commit
to kahou82/argo-cd
that referenced
this pull request
Mar 9, 2025
…rgoproj#22095) Signed-off-by: Blake Pettersson <blake.pettersson@gmail.com> Signed-off-by: Kahou Lei <kahou82@gmail.com>
Aaron-9900
pushed a commit
to Aaron-9900/argo-cd
that referenced
this pull request
Apr 7, 2025
…rgoproj#22095) Signed-off-by: Blake Pettersson <blake.pettersson@gmail.com>
14 tasks
Aaron-9900
pushed a commit
to Aaron-9900/argo-cd
that referenced
this pull request
Apr 7, 2025
…rgoproj#22095) Signed-off-by: Blake Pettersson <blake.pettersson@gmail.com>
14 tasks
Aaron-9900
pushed a commit
to Aaron-9900/argo-cd
that referenced
this pull request
Apr 7, 2025
…rgoproj#22095) Signed-off-by: Blake Pettersson <blake.pettersson@gmail.com>
Aaron-9900
pushed a commit
to Aaron-9900/argo-cd
that referenced
this pull request
Apr 7, 2025
…rgoproj#22095) Signed-off-by: Blake Pettersson <blake.pettersson@gmail.com>
rumstead
pushed a commit
that referenced
this pull request
Apr 7, 2025
…22095, #20978) (#22583) Signed-off-by: Michal Ryšavý <michal.rysavy@ext.csas.cz> Signed-off-by: Blake Pettersson <blake.pettersson@gmail.com> Co-authored-by: Michal Ryšavý <mrysavy@users.noreply.github.com> Co-authored-by: Michal Ryšavý <michal.rysavy@ext.csas.cz> Co-authored-by: Blake Pettersson <blake.pettersson@gmail.com>
Hapshanko
pushed a commit
to Hapshanko/argo-cd
that referenced
this pull request
Apr 29, 2025
…rgoproj#22095) Signed-off-by: Blake Pettersson <blake.pettersson@gmail.com> Signed-off-by: Hapshanko <adamgaming391100@gmail.com>
14 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SelfHealAttemptsCountshould be reset when either a new revision is available or if the same revision has previously successfully synced. Fixes #21599.Checklist: