fix: Fix calculating SelfHealBackOff delay when exceeding maximum (#20976)

[mrysavy]

Fixes [ISSUE #20976]

This PR fixes calculating of SelfHealBackOff delay when the delay exceeds maximum

Checklist:

• Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this does not need to be in the release notes.
• The title of the PR states what changed and the related issues number (used for the release note).
• The title of the PR conforms to the Toolchain Guide
• I've included "Closes [ISSUE #]" or "Fixes [ISSUE #]" in the description to automatically close the associated issue.
• I've updated both the CLI and UI to expose my feature, or I plan to submit a second PR with them.
• Does this PR require documentation updates?
• I've updated documentation as required by this PR.
• I have signed off all my commits as required by DCO
• I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
• My build is green (troubleshooting builds).
• My new feature complies with the feature status guidelines.
• I have added a brief description of why this PR is necessary and/or what this PR solves.
• Optional. My organization is added to USERS.md.
• Optional. For bug fixes, I've indicated what older releases this fix should be cherry-picked into (this may or may not happen depending on risk/complexity).

[bunnyshell]

❌ Preview Environment deleted from Bunnyshell

Available commands (reply to this comment):

• 🚀 /bns:deploy to deploy the environment

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 54.99%. Comparing base (02d6866) to head (ebbf5c7).
Report is 513 commits behind head on master.

Additional details and impacted files

@@            Coverage Diff             @@
##           master   #20978      +/-   ##
==========================================
- Coverage   55.03%   54.99%   -0.04%     
==========================================
  Files         324      324              
  Lines       55466    55467       +1     
==========================================
- Hits        30526    30506      -20     
- Misses      22330    22343      +13     
- Partials     2610     2618       +8     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[michalrysavy-ext95730]

Hi, is anything missing in this PR before it could be accepted?

[pasha-codefresh]

Yeah, it happens because

next = time.Duration(float64(duration) * factor)
		if cap > 0 && next > cap {
			next = cap
			steps = 0
		}

Inside backoff library, it is marking steps as 0 and setup next with correct value, and just because of backOff.Steps > 0 we never reach last iteration.

Just leaving as explanation for future

[pasha-codefresh]

You still potentially can pass max int value as backoff , but it will not have any performance impact, because here exit in the function if steps are 0

[pasha-codefresh]

Hovewer we can change the loop a bit, but i think it is overcomplicate it without significant benefit

for i := 0; i < steps; i++ {
	delay = backOff.Step()
	
	if i != steps - 1 && backOff.Steps == 0 {
		delay = backOff.Duration
		break
	}
	
}

[pasha-codefresh]

LGTM, thank you