Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Remove sleep from when/then in e2e tests #21008

Conversation

andrii-korotkov-verkada
Copy link
Contributor

@andrii-korotkov-verkada andrii-korotkov-verkada commented Nov 30, 2024

These sleeps might be unnecessary, remove them and check the e2e tests.

Closes #21007

Checklist:

  • Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this does not need to be in the release notes.
  • The title of the PR states what changed and the related issues number (used for the release note).
  • The title of the PR conforms to the Toolchain Guide
  • I've included "Closes [ISSUE #]" or "Fixes [ISSUE #]" in the description to automatically close the associated issue.
  • I've updated both the CLI and UI to expose my feature, or I plan to submit a second PR with them.
  • Does this PR require documentation updates?
  • I've updated documentation as required by this PR.
  • I have signed off all my commits as required by DCO
  • I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
  • My build is green (troubleshooting builds).
  • My new feature complies with the feature status guidelines.
  • I have added a brief description of why this PR is necessary and/or what this PR solves.
  • Optional. My organization is added to USERS.md.
  • Optional. For bug fixes, I've indicated what older releases this fix should be cherry-picked into (this may or may not happen depending on risk/complexity).

These sleeps might be unnecessary, remove them and check the e2e tests.

Closes argoproj#21007

Signed-off-by: Andrii Korotkov <[email protected]>
Copy link

bunnyshell bot commented Nov 30, 2024

❌ Preview Environment deleted from Bunnyshell

Available commands (reply to this comment):

  • 🚀 /bns:deploy to deploy the environment

Copy link

codecov bot commented Nov 30, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 55.05%. Comparing base (02d6866) to head (d325622).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master   #21008      +/-   ##
==========================================
+ Coverage   55.03%   55.05%   +0.01%     
==========================================
  Files         324      324              
  Lines       55466    55466              
==========================================
+ Hits        30526    30537      +11     
+ Misses      22330    22321       -9     
+ Partials     2610     2608       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@andrii-korotkov-verkada
Copy link
Contributor Author

Turns out we can just do it, saves ~5 min.

Before:
Screenshot 2024-11-29 at 6 36 49 PM
Screenshot 2024-11-29 at 6 36 55 PM

After:
Screenshot 2024-11-29 at 6 36 24 PM
Screenshot 2024-11-29 at 6 36 32 PM

@revitalbarletz
Copy link
Contributor

One question, why were the sleep there in the first place?

@andrii-korotkov-verkada
Copy link
Contributor Author

One question, why were the sleep there in the first place?

I don't know, I couldn't find an explanation, but the code is very old.

Copy link
Member

@crenshaw-dev crenshaw-dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems fine, let's give it a whirl. If we see an increase in flakes, we'll tackle those.

@crenshaw-dev crenshaw-dev merged commit 8320f88 into argoproj:master Nov 30, 2024
33 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Try optimizing e2e tests by removing potentially redundant sleeps from When/Then
3 participants