-
Notifications
You must be signed in to change notification settings - Fork 5.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Remove sleep from when/then in e2e tests #21008
chore: Remove sleep from when/then in e2e tests #21008
Conversation
These sleeps might be unnecessary, remove them and check the e2e tests. Closes argoproj#21007 Signed-off-by: Andrii Korotkov <[email protected]>
❌ Preview Environment deleted from BunnyshellAvailable commands (reply to this comment):
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #21008 +/- ##
==========================================
+ Coverage 55.03% 55.05% +0.01%
==========================================
Files 324 324
Lines 55466 55466
==========================================
+ Hits 30526 30537 +11
+ Misses 22330 22321 -9
+ Partials 2610 2608 -2 ☔ View full report in Codecov by Sentry. |
One question, why were the sleep there in the first place? |
I don't know, I couldn't find an explanation, but the code is very old. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems fine, let's give it a whirl. If we see an increase in flakes, we'll tackle those.
These sleeps might be unnecessary, remove them and check the e2e tests. Closes argoproj#21007 Signed-off-by: Andrii Korotkov <[email protected]> Signed-off-by: Adrian Aneci <[email protected]>
These sleeps might be unnecessary, remove them and check the e2e tests. Closes argoproj#21007 Signed-off-by: Andrii Korotkov <[email protected]>
These sleeps might be unnecessary, remove them and check the e2e tests.
Closes #21007
Checklist: