Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Try optimizing e2e tests by removing potentially redundant sleeps from When/Then #21007

Closed
andrii-korotkov-verkada opened this issue Nov 30, 2024 · 0 comments · Fixed by #21008
Assignees
Labels
component:test Test requests (e2e or unit) enhancement New feature or request

Comments

@andrii-korotkov-verkada
Copy link
Contributor

Summary

One example is When, which has a sleep for 1 second, e.g.

func (c *Context) When() *Actions {
// in case any settings have changed, pause for 1s, not great, but fine
time.Sleep(1 * time.Second)
return &Actions{context: c}
}

Maybe it can be removed or reduced. This would require some exploration and experimentation.

Motivation

Improve e2e tests run time.

Proposal

Explore why certain sleeps are there and experiment with removing them.

@andrii-korotkov-verkada andrii-korotkov-verkada added enhancement New feature or request component:test Test requests (e2e or unit) labels Nov 30, 2024
andrii-korotkov-verkada added a commit to andrii-korotkov-verkada/argo-cd that referenced this issue Nov 30, 2024
These sleeps might be unnecessary, remove them and check the e2e tests.

Closes argoproj#21007

Signed-off-by: Andrii Korotkov <[email protected]>
@andrii-korotkov-verkada andrii-korotkov-verkada changed the title Try optimizing e2e tests by removing potentially redundant sleeps Try optimizing e2e tests by removing potentially redundant sleeps from When/Then Nov 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:test Test requests (e2e or unit) enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant