-
Notifications
You must be signed in to change notification settings - Fork 5.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Remove or reduce sleep in e2e tests #21010
Merged
crenshaw-dev
merged 2 commits into
argoproj:master
from
andrii-korotkov-verkada:21009-try-removing-sleep-from-e2e-tests
Dec 2, 2024
Merged
chore: Remove or reduce sleep in e2e tests #21010
crenshaw-dev
merged 2 commits into
argoproj:master
from
andrii-korotkov-verkada:21009-try-removing-sleep-from-e2e-tests
Dec 2, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closes argoproj#21009 Some sleeps may no longer be necessary or be too long. Try removing or reducing duration. Signed-off-by: Andrii Korotkov <[email protected]>
❌ Preview Environment deleted from BunnyshellAvailable commands (reply to this comment):
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #21010 +/- ##
=========================================
Coverage ? 55.07%
=========================================
Files ? 324
Lines ? 55466
Branches ? 0
=========================================
Hits ? 30549
Misses ? 22310
Partials ? 2607 ☔ View full report in Codecov by Sentry. |
Seems to save about 1 minute. To be safe, may need to re-run tests after #21008 is merged. |
crenshaw-dev
approved these changes
Dec 2, 2024
adriananeci
pushed a commit
to adriananeci/argo-cd
that referenced
this pull request
Dec 4, 2024
Closes argoproj#21009 Some sleeps may no longer be necessary or be too long. Try removing or reducing duration. Signed-off-by: Andrii Korotkov <[email protected]> Co-authored-by: Michael Crenshaw <[email protected]> Signed-off-by: Adrian Aneci <[email protected]>
revitalbarletz
pushed a commit
to revitalbarletz/argo-cd
that referenced
this pull request
Jan 20, 2025
Closes argoproj#21009 Some sleeps may no longer be necessary or be too long. Try removing or reducing duration. Signed-off-by: Andrii Korotkov <[email protected]> Co-authored-by: Michael Crenshaw <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #21009
Some sleeps may no longer be necessary or be too long. Try removing or reducing duration.
Checklist: