Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Remove or reduce sleep in e2e tests #21010

Conversation

andrii-korotkov-verkada
Copy link
Contributor

@andrii-korotkov-verkada andrii-korotkov-verkada commented Nov 30, 2024

Closes #21009

Some sleeps may no longer be necessary or be too long. Try removing or reducing duration.

Checklist:

  • Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this does not need to be in the release notes.
  • The title of the PR states what changed and the related issues number (used for the release note).
  • The title of the PR conforms to the Toolchain Guide
  • I've included "Closes [ISSUE #]" or "Fixes [ISSUE #]" in the description to automatically close the associated issue.
  • I've updated both the CLI and UI to expose my feature, or I plan to submit a second PR with them.
  • Does this PR require documentation updates?
  • I've updated documentation as required by this PR.
  • I have signed off all my commits as required by DCO
  • I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
  • My build is green (troubleshooting builds).
  • My new feature complies with the feature status guidelines.
  • I have added a brief description of why this PR is necessary and/or what this PR solves.
  • Optional. My organization is added to USERS.md.
  • Optional. For bug fixes, I've indicated what older releases this fix should be cherry-picked into (this may or may not happen depending on risk/complexity).

Closes argoproj#21009

Some sleeps may no longer be necessary or be too long. Try removing or reducing duration.

Signed-off-by: Andrii Korotkov <[email protected]>
Copy link

bunnyshell bot commented Nov 30, 2024

❌ Preview Environment deleted from Bunnyshell

Available commands (reply to this comment):

  • 🚀 /bns:deploy to deploy the environment

Copy link

codecov bot commented Nov 30, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Please upload report for BASE (master@8320f88). Learn more about missing BASE report.
Report is 7 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff            @@
##             master   #21010   +/-   ##
=========================================
  Coverage          ?   55.07%           
=========================================
  Files             ?      324           
  Lines             ?    55466           
  Branches          ?        0           
=========================================
  Hits              ?    30549           
  Misses            ?    22310           
  Partials          ?     2607           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@andrii-korotkov-verkada
Copy link
Contributor Author

Seems to save about 1 minute. To be safe, may need to re-run tests after #21008 is merged.

Before:
Screenshot 2024-11-30 at 5 34 24 AM
Screenshot 2024-11-30 at 5 34 32 AM

After:
Screenshot 2024-11-30 at 5 34 40 AM
Screenshot 2024-11-30 at 5 34 45 AM

@crenshaw-dev crenshaw-dev merged commit 5fc306e into argoproj:master Dec 2, 2024
27 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Try optimizing e2e tests by removing potentially redundant sleeps from tests themselves
2 participants