fix: failing lint and unit test#16275
Merged
blakepettersson merged 1 commit intoargoproj:masterfrom Nov 8, 2023
Merged
Conversation
Signed-off-by: mikutas <23391543+mikutas@users.noreply.github.com>
13 tasks
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #16275 +/- ##
=======================================
Coverage 49.51% 49.52%
=======================================
Files 269 269
Lines 46990 46990
=======================================
+ Hits 23269 23272 +3
+ Misses 21437 21435 -2
+ Partials 2284 2283 -1 ☔ View full report in Codecov by Sentry. |
Member
|
/cherry-pick release-2.8 |
Member
|
/cherry-pick release-2.9 |
blakepettersson
added
the
ready-for-review
13 tasks
13 tasks
ishitasequeira
approved these changes
Nov 8, 2023
13 tasks
13 tasks
|
Cherry-pick failed with |
|
Cherry-pick failed with |
jmilic1
pushed a commit
to jmilic1/argo-cd
that referenced
this pull request
Nov 13, 2023
Signed-off-by: mikutas <23391543+mikutas@users.noreply.github.com> Signed-off-by: jmilic1 <70441727+jmilic1@users.noreply.github.com>
blakepettersson
pushed a commit
to blakepettersson/argo-cd
that referenced
this pull request
Nov 14, 2023
Signed-off-by: mikutas <23391543+mikutas@users.noreply.github.com>
13 tasks
blakepettersson
pushed a commit
to blakepettersson/argo-cd
that referenced
this pull request
Nov 14, 2023
Signed-off-by: mikutas <23391543+mikutas@users.noreply.github.com> Signed-off-by: Blake Pettersson <blake.pettersson@gmail.com>
vladfr
pushed a commit
to vladfr/argo-cd
that referenced
this pull request
Dec 13, 2023
Signed-off-by: mikutas <23391543+mikutas@users.noreply.github.com>
tesla59
pushed a commit
to tesla59/argo-cd
that referenced
this pull request
Dec 16, 2023
Signed-off-by: mikutas <23391543+mikutas@users.noreply.github.com>
lyda
pushed a commit
to lyda/argo-cd
that referenced
this pull request
Mar 28, 2024
Signed-off-by: mikutas <23391543+mikutas@users.noreply.github.com> Signed-off-by: Kevin Lyda <kevin@lyda.ie>
Hariharasuthan99
pushed a commit
to AmadeusITGroup/argo-cd
that referenced
this pull request
Jun 16, 2024
Signed-off-by: mikutas <23391543+mikutas@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #16278
relates to #15670
Checklist: