feat(cli): Added example to admin-cluster.go and projectwindow.go files by surajyadav1108 · Pull Request #16128 · argoproj/argo-cd

surajyadav1108 · 2023-10-26T17:46:59Z

part of the issue #15690
and part of the PR #16103

resolved issues

Checklist:

Signed-off-by: Surajyadav <harrypotter1108@gmail.com>

codecov · 2023-10-26T18:10:36Z

Codecov Report

Attention: 73 lines in your changes are missing coverage. Please review.

Comparison is base (1600c03) 49.53% compared to head (8f4f67c) 49.46%.

Files	Patch %	Lines
cmd/argocd/commands/projectwindows.go	0.00%	43 Missing ⚠️
cmd/argocd/commands/admin/cluster.go	0.00%	30 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##           master   #16128      +/-   ##
==========================================
- Coverage   49.53%   49.46%   -0.08%     
==========================================
  Files         269      269              
  Lines       47222    47289      +67     
==========================================
  Hits        23392    23392              
- Misses      21530    21597      +67     
  Partials     2300     2300

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

crenshaw-dev

I think many of these examples rely too heavily on demonstrating global flags. Can you rework the examples to rely only on flags specific to the command?

surajyadav1108 · 2023-10-29T08:02:31Z

@crenshaw-dev hmm looking back to it yes you are correct, I will do the required changes

Signed-off-by: Surajyadav <harrypotter1108@gmail.com>

surajyadav1108 · 2023-10-30T05:34:06Z

@crenshaw-dev made the changes. up for review

cmd/argocd/commands/admin/cluster.go

cmd/argocd/commands/projectwindows.go

Signed-off-by: Surajyadav <harrypotter1108@gmail.com>

cmd/argocd/commands/projectwindows.go

Signed-off-by: Surajyadav <harrypotter1108@gmail.com>

cmd/argocd/commands/admin/cluster.go

cmd/argocd/commands/projectwindows.go

Signed-off-by: Surajyadav <harrypotter1108@gmail.com>

surajyadav1108 · 2023-11-04T09:53:12Z

@ishitasequeira build test UI code is failing even after retriggering. You can try a manual build to check for errors. I haven't changed anything apart from correcting a spelling mistake, so this check should pass.

Signed-off-by: Surajyadav <harrypotter1108@gmail.com>

surajyadav1108 · 2023-11-08T11:51:12Z

@ishitasequeira ok found out why the Build test UI code was failing and fixed it but after updating the branch by pulling in from upstream there were some issues in code that has already been merged into upstream master and that's why my master update check fails for lint and tests but there is a open PR correcting this issue
#16275 I believe after that PR merge it will resolve these errors too.

ishitasequeira

@surajyadav1108 , Please rebase the PR again. The PR #16275 is merged.

Signed-off-by: Surajyadav <harrypotter1108@gmail.com>

surajyadav1108 · 2023-11-11T07:44:26Z

Updating the master branch had no issues as it should be. @ishitasequeira

ishitasequeira

Thanks @surajyadav1108 !! LGTM!!

surajyadav1108 · 2023-11-17T10:06:04Z

@ishitasequeira is there anything stopping auto-merge?

ishitasequeira

Thanks @surajyadav1108 for addressing all the comments. Will merge the PR.

Fixed

…es (argoproj#16128) * cluster.go, projectwindow.go Signed-off-by: Surajyadav <harrypotter1108@gmail.com> * updated-examples Signed-off-by: Surajyadav <harrypotter1108@gmail.com> * format-corrected Signed-off-by: Surajyadav <harrypotter1108@gmail.com> * spell-mistake Signed-off-by: Surajyadav <harrypotter1108@gmail.com> * format-correction Signed-off-by: Surajyadav <harrypotter1108@gmail.com> * retrigger Signed-off-by: Surajyadav <harrypotter1108@gmail.com> * retrigger-2 Signed-off-by: Surajyadav <harrypotter1108@gmail.com> * retirgger-3 Signed-off-by: Surajyadav <harrypotter1108@gmail.com> * update Signed-off-by: Surajyadav <harrypotter1108@gmail.com> --------- Signed-off-by: Surajyadav <harrypotter1108@gmail.com> Co-authored-by: Ishita Sequeira <46771830+ishitasequeira@users.noreply.github.com>

…es (argoproj#16128) * cluster.go, projectwindow.go Signed-off-by: Surajyadav <harrypotter1108@gmail.com> * updated-examples Signed-off-by: Surajyadav <harrypotter1108@gmail.com> * format-corrected Signed-off-by: Surajyadav <harrypotter1108@gmail.com> * spell-mistake Signed-off-by: Surajyadav <harrypotter1108@gmail.com> * format-correction Signed-off-by: Surajyadav <harrypotter1108@gmail.com> * retrigger Signed-off-by: Surajyadav <harrypotter1108@gmail.com> * retrigger-2 Signed-off-by: Surajyadav <harrypotter1108@gmail.com> * retirgger-3 Signed-off-by: Surajyadav <harrypotter1108@gmail.com> * update Signed-off-by: Surajyadav <harrypotter1108@gmail.com> --------- Signed-off-by: Surajyadav <harrypotter1108@gmail.com> Co-authored-by: Ishita Sequeira <46771830+ishitasequeira@users.noreply.github.com> Signed-off-by: Kevin Lyda <kevin@lyda.ie>

…es (argoproj#16128) * cluster.go, projectwindow.go Signed-off-by: Surajyadav <harrypotter1108@gmail.com> * updated-examples Signed-off-by: Surajyadav <harrypotter1108@gmail.com> * format-corrected Signed-off-by: Surajyadav <harrypotter1108@gmail.com> * spell-mistake Signed-off-by: Surajyadav <harrypotter1108@gmail.com> * format-correction Signed-off-by: Surajyadav <harrypotter1108@gmail.com> * retrigger Signed-off-by: Surajyadav <harrypotter1108@gmail.com> * retrigger-2 Signed-off-by: Surajyadav <harrypotter1108@gmail.com> * retirgger-3 Signed-off-by: Surajyadav <harrypotter1108@gmail.com> * update Signed-off-by: Surajyadav <harrypotter1108@gmail.com> --------- Signed-off-by: Surajyadav <harrypotter1108@gmail.com> Co-authored-by: Ishita Sequeira <46771830+ishitasequeira@users.noreply.github.com>

cluster.go, projectwindow.go

5fb4a3e

Signed-off-by: Surajyadav <harrypotter1108@gmail.com>

surajyadav1108 requested review from a team as code owners October 26, 2023 17:46

crenshaw-dev added the group:hacktoberfest-2023 Hacktoberfest 2023 label Oct 27, 2023

crenshaw-dev changed the title ~~feat: Added example to admin-cluster.go and projectwindow.go files (RESOLVED)~~ feat(cli): Added example to admin-cluster.go and projectwindow.go files Oct 28, 2023

crenshaw-dev previously requested changes Oct 28, 2023

View reviewed changes

surajyadav1108 added 2 commits October 29, 2023 20:23

updateMerge branch 'master' of https://github.com/argoproj/argo-cd

5156ae5

updated-examples

c7d4386

Signed-off-by: Surajyadav <harrypotter1108@gmail.com>

Merge branch 'master' of https://github.com/argoproj/argo-cd

cc3385d

surajyadav1108 requested a review from crenshaw-dev November 1, 2023 10:18

Merge branch 'master' into master

875c161

ishitasequeira requested changes Nov 2, 2023

View reviewed changes

cmd/argocd/commands/admin/cluster.go Show resolved Hide resolved

cmd/argocd/commands/projectwindows.go Outdated Show resolved Hide resolved

cmd/argocd/commands/projectwindows.go Outdated Show resolved Hide resolved

surajyadav1108 added 4 commits November 2, 2023 14:55

Merge branch 'master' into master

659ff0b

Merge branch 'master' of https://github.com/argoproj/argo-cd

8504e14

format-corrected

63f8e95

Signed-off-by: Surajyadav <harrypotter1108@gmail.com>

Merge branch 'master' of https://github.com/surajyadav1108/argo-cd

7a3241d

surajyadav1108 requested a review from ishitasequeira November 2, 2023 10:28

chengfang reviewed Nov 2, 2023

View reviewed changes

cmd/argocd/commands/projectwindows.go Outdated Show resolved Hide resolved

chengfang reviewed Nov 2, 2023

View reviewed changes

cmd/argocd/commands/projectwindows.go Outdated Show resolved Hide resolved

surajyadav1108 added 2 commits November 2, 2023 22:20

Merge branch 'master' into master

bb5e62f

spell-mistake

4fe14f6

Signed-off-by: Surajyadav <harrypotter1108@gmail.com>

surajyadav1108 requested a review from chengfang November 2, 2023 17:23

chengfang approved these changes Nov 2, 2023

View reviewed changes

ishitasequeira requested changes Nov 3, 2023

View reviewed changes

cmd/argocd/commands/admin/cluster.go Outdated Show resolved Hide resolved

cmd/argocd/commands/projectwindows.go Outdated Show resolved Hide resolved

surajyadav1108 added 3 commits November 4, 2023 12:30

Merge branch 'master' into master

12778a1

format-correction

4d86d5d

Signed-off-by: Surajyadav <harrypotter1108@gmail.com>

retrigger

10299ad

Signed-off-by: Surajyadav <harrypotter1108@gmail.com>

retrigger-2

9197899

Signed-off-by: Surajyadav <harrypotter1108@gmail.com>

surajyadav1108 requested a review from ishitasequeira November 4, 2023 09:48

surajyadav1108 added 3 commits November 4, 2023 16:09

retirgger-3

dea5373

Signed-off-by: Surajyadav <harrypotter1108@gmail.com>

Merge branch 'master' into master

df01be2

Merge branch 'master' into master

321bb81

ishitasequeira approved these changes Nov 9, 2023

View reviewed changes

ishitasequeira enabled auto-merge (squash) November 9, 2023 03:03

ishitasequeira and others added 2 commits November 8, 2023 22:03

Merge branch 'master' into master

7edffa9

update

a8dc75e

Signed-off-by: Surajyadav <harrypotter1108@gmail.com>

auto-merge was automatically disabled November 9, 2023 07:58
Head branch was pushed to by a user without write access

Merge branch 'master' into master

d4cc3e7

surajyadav1108 requested a review from ishitasequeira November 11, 2023 07:43

ishitasequeira approved these changes Nov 16, 2023

View reviewed changes

ishitasequeira enabled auto-merge (squash) November 16, 2023 12:32

Merge branch 'master' into master

e215937

surajyadav1108 added 2 commits November 18, 2023 21:37

Merge branch 'master' into master

48be1b2

Merge branch 'master' into master

8f4f67c

ishitasequeira approved these changes Nov 30, 2023

View reviewed changes

ishitasequeira merged commit 8070725 into argoproj:master Nov 30, 2023

surajyadav1108 mentioned this pull request Dec 4, 2024

REQUEST: New membership for @surajyadav1108 argoproj/argoproj#346

Closed

6 tasks

Conversation

surajyadav1108 commented Oct 26, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

codecov bot commented Oct 26, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

crenshaw-dev left a comment

Choose a reason for hiding this comment

Uh oh!

surajyadav1108 commented Oct 29, 2023

Uh oh!

surajyadav1108 commented Oct 30, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

surajyadav1108 commented Nov 4, 2023

Uh oh!

surajyadav1108 commented Nov 8, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

ishitasequeira left a comment

Choose a reason for hiding this comment

Uh oh!

surajyadav1108 commented Nov 11, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

ishitasequeira left a comment

Choose a reason for hiding this comment

Uh oh!

surajyadav1108 commented Nov 17, 2023

Uh oh!

ishitasequeira left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

surajyadav1108 commented Oct 26, 2023 •

edited

Loading

codecov bot commented Oct 26, 2023 •

edited

Loading

surajyadav1108 commented Oct 30, 2023 •

edited

Loading

surajyadav1108 commented Nov 8, 2023 •

edited

Loading

surajyadav1108 commented Nov 11, 2023 •

edited

Loading