fix: Sticking to DNS label standard in branch_slug (Gitlab PR Generators)#10801
Closed
Aym3nTN wants to merge 3 commits intoargoproj:masterfrom
Closed
fix: Sticking to DNS label standard in branch_slug (Gitlab PR Generators)#10801Aym3nTN wants to merge 3 commits intoargoproj:masterfrom
Aym3nTN wants to merge 3 commits intoargoproj:masterfrom
Conversation
Fixes: argoproj#10622 Signed-off-by: cleverhu <shouping.hu@daocloud.io>
Signed-off-by: Aymen Ben Tanfous <aymen.bentanfous@gmail.com>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #10801 +/- ##
=======================================
Coverage 45.67% 45.67%
=======================================
Files 236 236
Lines 28697 28702 +5
=======================================
+ Hits 13106 13109 +3
- Misses 13799 13800 +1
- Partials 1792 1793 +1 ☔ View full report in Codecov by Sentry. |
Contributor
Author
|
@crenshaw-dev is it possible to pick this on v2.5 release with this ticket? #9540 (comment) |
crenshaw-dev
requested changes
Oct 7, 2022
Member
crenshaw-dev
left a comment
There was a problem hiding this comment.
Thanks @Aym3nTN! I proposed an alternative solution here: #10622 (comment)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#10622
Building on top of this PR #10698 (not sure if it's the right to do it though)
I had to fix these 2 issues in the gosimple/slug package: gosimple/slug#77 and gosimple/slug#75
link next to the DCO action for instructions on how to resolve this.
Checklist: