feat: Added the ability to filter MRs by 'state' to Gitlab PR Generator#9540
Merged
crenshaw-dev merged 2 commits intoargoproj:masterfrom Jun 8, 2022
Merged
feat: Added the ability to filter MRs by 'state' to Gitlab PR Generator#9540crenshaw-dev merged 2 commits intoargoproj:masterfrom
crenshaw-dev merged 2 commits intoargoproj:masterfrom
Conversation
Codecov Report
@@ Coverage Diff @@
## master #9540 +/- ##
=======================================
Coverage 45.89% 45.90%
=======================================
Files 222 222
Lines 26458 26461 +3
=======================================
+ Hits 12143 12146 +3
Misses 12658 12658
Partials 1657 1657
Continue to review full report at Codecov.
|
crenshaw-dev
reviewed
Jun 8, 2022
Member
crenshaw-dev
left a comment
crenshaw-dev
left a comment
There was a problem hiding this comment.
LGTM! Can you add a line to the docs mentioning the filter?
added 2 commits
June 8, 2022 17:54
Simplied state verification + Added Unit test Signed-off-by: Aymen Ben Tanfous <aymen.bentanfous@cimpress.com>
Signed-off-by: Aymen Ben Tanfous <aymen.bentanfous@cimpress.com>
crenshaw-dev
approved these changes
Jun 8, 2022
Contributor
Author
|
@crenshaw-dev would this feat and this one #9462 be release in the next release? I'm not yet familiar with the release way and cadence in argo project. |
Member
|
@Aym3nTN this will be in 2.5, which is expected in August. |
Aym3nTN
added a commit
to Aym3nTN/argo-cd
that referenced
this pull request
Sep 15, 2022
…or (argoproj#9540) * Added the ability to filter MRs by 'state' to Gitlab PR Generator Simplied state verification + Added Unit test Signed-off-by: Aymen Ben Tanfous <aymen.bentanfous@cimpress.com> * Updated the doc Signed-off-by: Aymen Ben Tanfous <aymen.bentanfous@cimpress.com> Co-authored-by: Aymen Ben Tanfous <aymen.bentanfous@cimpress.com>
10 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Aymen Ben Tanfous aymen.bentanfous@cimpress.com
Closes: #9539
Checklist: