fix branch slug

[cleverhu]

Note on DCO:

If the DCO action in the integration test fails, one or more of your commits are not signed off. Please click on the Details link next to the DCO action for instructions on how to resolve this.

Checklist:

• Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this does not need to be in the release notes.
• The title of the PR states what changed and the related issues number (used for the release note).
• I've included "Closes [ISSUE #]" or "Fixes [ISSUE #]" in the description to automatically close the associated issue.
• I've updated both the CLI and UI to expose my feature, or I plan to submit a second PR with them.
• Does this PR require documentation updates?
• I've updated documentation as required by this PR.
• Optional. My organization is added to USERS.md.
• I have signed off all my commits as required by DCO
• I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
• My build is green (troubleshooting builds).

[codecov]

Codecov Report

Attention: Patch coverage is 66.66667% with 2 lines in your changes missing coverage. Please review.

Project coverage is 45.76%. Comparing base (02bf903) to head (948cb5a).
Report is 2545 commits behind head on master.

Files	Patch %	Lines
applicationset/generators/pull_request.go	66.66%	1 Missing and 1 partial ⚠️

Additional details and impacted files

@@           Coverage Diff           @@
##           master   #10698   +/-   ##
=======================================
  Coverage   45.75%   45.76%           
=======================================
  Files         236      236           
  Lines       28527    28533    +6     
=======================================
+ Hits        13053    13057    +4     
- Misses      13669    13670    +1     
- Partials     1805     1806    +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[jannfis]

I wonder, is the comment just plainly wrong? It talks about suffixing the slug with 13 additional characters. If we increase the max. length to 63 here, it can't be suffixed anymore.

Can you please elaborate on this change?

[cleverhu]

I checked the code, i don't find the code for generate. So I think it is ok to change the max length of branch-slug to 63, and it is was mentioned in #10622.

[crenshaw-dev]

Superseded by #10801