Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Support other namespaces than argocd in AIU #763

Merged
merged 15 commits into from
Jul 11, 2024
Merged

feat: Support other namespaces than argocd in AIU #763

merged 15 commits into from
Jul 11, 2024

Conversation

sribiere-jellysmack
Copy link
Contributor

When trying to update an application in another namespace than argocd, AIU should include namespace in logs, and in writeback file.

@codecov-commenter
Copy link

codecov-commenter commented Jul 1, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 63.09%. Comparing base (5edb9d0) to head (53f4a17).

Additional details and impacted files 
@@            Coverage Diff             @@
##           master     #763      +/-   ##
==========================================
+ Coverage   63.00%   63.09%   +0.08%     
==========================================
  Files          31       31              
  Lines        3117     3124       +7     
==========================================
+ Hits         1964     1971       +7     
  Misses       1009     1009              
  Partials      144      144

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

chengfang
chengfang reviewed Jul 1, 2024
View reviewed changes
Copy link
Collaborator

@chengfang chengfang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you fix the DCO check? Fixing the DCO in this PR should be as simple as running

git commit --amend -s
in your local PR branch and then force-pushing.

cmd/ask_pass_test.go Outdated Show resolved Hide resolved
go.mod Outdated Show resolved Hide resolved
pkg/argocd/update_test.go Outdated Show resolved Hide resolved
pkg/common/constants.go Show resolved Hide resolved
jannfis
jannfis reviewed Jul 2, 2024
View reviewed changes
pkg/argocd/update.go Outdated Show resolved Hide resolved
sribiere-jellysmack and others added 12 commits July 9, 2024 15:03
@sribiere-jellysmack
feat: application in other namespaces
7b64abe 
Signed-off-by: Sebastien RIBIERE <[email protected]>
@sribiere-jellysmack
test: add tests with other Namespace
aa5c520 
Signed-off-by: Sebastien RIBIERE <[email protected]>
@sribiere-jellysmack
test: add tests with other Namespace
7dadcc5 
Signed-off-by: Sebastien RIBIERE <[email protected]>
@chengfang @sribiere-jellysmack
add unit tests for cmd/main.go and cmd/run.go (#764)
f211b69 
Signed-off-by: Cheng Fang <[email protected]>
Signed-off-by: Sebastien RIBIERE <[email protected]>
@chengfang @sribiere-jellysmack
fix: add check for the optional ref.Platform field to avoid nil point…
cf08ef6 
…er in TagInfoFromReferences (#759)

Signed-off-by: Cheng Fang <[email protected]>
Signed-off-by: Sebastien RIBIERE <[email protected]>
@Mangaal @sribiere-jellysmack
chore(tests): add unit tests for cmd/template.go, cmd/util.go and cmd…
edae35a 
…/version.go (#765)

Signed-off-by: Mangaal <[email protected]>
Signed-off-by: Sebastien RIBIERE <[email protected]>
@chengfang @sribiere-jellysmack
chore(tests): add unit tests for cmd/test.go (#766)
1c1f78a 
Signed-off-by: Cheng Fang <[email protected]>
Signed-off-by: Sebastien RIBIERE <[email protected]>
@jannfis @sribiere-jellysmack
fix: Fix write-back commits (#767)
53d3ad8 
Signed-off-by: jannfis <[email protected]>
Signed-off-by: Sebastien RIBIERE <[email protected]>
@chengfang @sribiere-jellysmack
tests: add unit tests for pkg/options.go and pkg/metrics.go (#768)
bc99aa8 
Signed-off-by: Cheng Fang <[email protected]>
Signed-off-by: Sebastien RIBIERE <[email protected]>
@chengfang @sribiere-jellysmack
tests: add unit tests for pkg/cache (#770)
2a28658 
Signed-off-by: Cheng Fang <[email protected]>
Signed-off-by: Sebastien RIBIERE <[email protected]>
@sribiere-jellysmack
fix: use apropriate Namespace
a5e8a41 
Signed-off-by: Sebastien RIBIERE <[email protected]>
@sribiere-jellysmack
fix: tests with use apropriate Namespace
b3da466 
Signed-off-by: Sebastien RIBIERE <[email protected]>
chengfang
chengfang reviewed Jul 9, 2024
View reviewed changes
pkg/argocd/update.go Outdated Show resolved Hide resolved
sribiere-jellysmack and others added 3 commits July 9, 2024 16:21
@sribiere-jellysmack
fix: Remove useless log
83dbed4 
Signed-off-by: Sebastien RIBIERE <[email protected]>
@sribiere-jellysmack
fix: lint
17f3dec 
Signed-off-by: Sebastien RIBIERE <[email protected]>
@sribiere-jellysmack
Merge branch 'master' into master
53f4a17
@chengfang chengfang merged commit 80d2731 into argoproj-labs:master Jul 11, 2024
10 checks passed
@chengfang
Copy link
Collaborator

Thanks @sribiere-jellysmack !

@NissesSenap NissesSenap mentioned this pull request Jul 12, 2024
Open
sribiere-jellysmack added a commit to sribiere-jellysmack/argocd-image-updater that referenced this pull request Aug 13, 2024
@sribiere-jellysmack @chengfang
@Mangaal @jannfis
feat: Support other namespaces than argocd in AIU (argoproj-labs#763)
34b879f 
Signed-off-by: Sebastien RIBIERE <[email protected]>
Signed-off-by: Cheng Fang <[email protected]>
Signed-off-by: Mangaal <[email protected]>
Signed-off-by: jannfis <[email protected]>
Co-authored-by: Cheng Fang <[email protected]>
Co-authored-by: Mangaal <[email protected]>
Co-authored-by: Jann Fischer <[email protected]>
@chengfang chengfang mentioned this pull request Dec 5, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jannfis jannfis jannfis left review comments

@chengfang chengfang chengfang approved these changes

@pasha-codefresh pasha-codefresh Awaiting requested review from pasha-codefresh pasha-codefresh is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@sribiere-jellysmack @codecov-commenter @chengfang @jannfis @Mangaal